search

NickvisionApps / Tagger

Tag your music
https://flathub.org/apps/details/org.nickvision.tagger
MIT License
219 stars 14 forks source link

Disc Tag Property #365

Closed kissthermite closed 10 months ago

kissthermite commented 10 months ago

Add Disc & Disc Total as an additional properties.

nlogozzo commented 10 months ago

Will add these to Addition Properties

Note to self, add an option to show and hide additional properties section for those who want/don't want it. Also, remember this option in config, default shown

nlogozzo commented 10 months ago

GNOME: image

Windows: image

nlogozzo commented 10 months ago

NOTE for GNOME: I wanted to place DiscNumber and DiscTotal in Additional Properties since that is what they are...but because we can't have two entries side by side without putting them in their own box (like Track and TrackTotal), I decided to put them underneath Track and TrackTotal so I didn't have to break up the Additional Properties.

nlogozzo commented 10 months ago

Please test the latest beta release with this feature: https://github.com/NickvisionApps/Tagger/releases/tag/2023.10.0-beta2 and let us know how it goes!

Will be available via flathub-beta within the hour

kissthermite commented 10 months ago

Please test the latest beta release with this feature: https://github.com/NickvisionApps/Tagger/releases/tag/2023.10.0-beta2 and let us know how it goes!

Will be available via flathub-beta within the hour

Will do!

nlogozzo commented 10 months ago

Will do!

The build was just uploaded and published. Give it literally 5-10 minutes and the update will be downloadable from the flathub-beta repo 😅 Instructions on the release page of how to get from flathub-beta if you never have before

kissthermite commented 10 months ago

Please test the latest beta release with this feature: https://github.com/NickvisionApps/Tagger/releases/tag/2023.10.0-beta2 and let us know how it goes!

image

Disc Number & Disc Total tag itself working as intended. However Sort Files By Album could do a little rework to accommodate Disc tag. The current behavior only take a consideration of Track. Also a little nitpick, why Track & Disc Number and not Track Number & Disc Number or Track & Disc?

kissthermite commented 10 months ago

However Sort Files By Album could do a little rework to accommodate Disc tag.

What i mean by this is it should be Disc Number first then Track Number so that when you have an Album that have multiple Disc E.g. Disc 1 contain 15 Track and the format of the Track Number is 1-15 and and Disc 2 contain 10 Track whether the Track Number is 1-10 or 16 -25 the sort will be the same.

nlogozzo commented 10 months ago

Also a little nitpick, why Track & Disc Number and not Track Number & Disc Number or Track & Disc?

As per tag specifications, track number is referred to as Track and disc number referred to as Disc Number. See https://community.mp3tag.de/t/a-few-questions-about-the-disc-number-disc-total-columns/18698/3 :

Value: %DISCNUMBER% Field: %DISCNUMBER% Value: %TRACK% Field: %TRACK%

nlogozzo commented 10 months ago

https://github.com/NickvisionApps/Tagger/releases/tag/2023.10.0-rc1