`VORBIS-VENDOR` on flac & opus, `info.ISFT` on wav Custom Properties are unremovable, The same behavior aren't present on mp3 and m4a

NickvisionApps / Tagger

Tag your music

https://flathub.org/apps/details/org.nickvision.tagger

MIT License

219 stars 14 forks source link

`VORBIS-VENDOR` on flac & opus, `info.ISFT` on wav Custom Properties are unremovable, The same behavior aren't present on mp3 and m4a #385

Closed kissthermite closed 10 months ago

kissthermite commented 10 months ago

nlogozzo commented 10 months ago

I believe these fields are required parts of the file's tag header and shouldn't really be considered "custom properties". I will find out...

nlogozzo commented 10 months ago

https://github.com/Zeugma440/atldotnet/issues/236

kissthermite commented 10 months ago

Wait. The proposed solution is to remove VORBIS VENDOR? how about moving it to File Properties instead?

nlogozzo commented 10 months ago

The proposed solution is to remove VORBIS VENDOR?

No the proposal is to hide VORBIS VENDOR from being shown as a "Custom Property" since it's supposed to be an encoded field of the codec used when the file is created. It isn't meant to be altered/deleted.

nlogozzo commented 10 months ago

how about moving it to File Properties instead?

We could do this, but the fact is it shouldn't be considered a Custom Property as I said before it's not to be edited/altered.

Showing it under File Properties is kind of useless too since it's more for music players to learn the codec of the file and not something concerning the tag.

kissthermite commented 10 months ago

Showing it under File Properties is kind of useless too since it's more for music players to learn the codec of the file and not something concerning the tag.

it's kinda useful for determining the origin of the file.

name

like this file right here. And pretty much all of my flac which i got from soulseek and deezer have identical VORBIS-VENDOR while the previous flac from this issue have unique VORBIS VENDOR which i guess it's because FFmpeg doing it's thing inside yt-dlp.

fsobolev commented 10 months ago

How about renaming "File properties" to "Read-only properties" and showing VORBIS-VENDOR and other things there if they are present in a file?

kissthermite commented 10 months ago

which i guess it's because FFmpeg doing it's thing inside yt-dlp.

Forgot to mention but all five files on this issue screenshot are obtained from YouTube Music via Parabolic

nlogozzo commented 10 months ago

How about renaming "File properties" to "Read-only properties" and showing VORBIS-VENDOR and other things there if they are present in a file?

I'll talk to ATL developer about having read only additional properties

nlogozzo commented 10 months ago

@kissthermite Hi! Could you do me a favor and email me one of the wav files containing info.ISFT that isn't getting removed. My email is nlogozzo225@gmail.com . Thanks!

kissthermite commented 10 months ago

@nlogozzo Sure. Just did it few moments ago.

nlogozzo commented 10 months ago

Turns out these fields are removable but there were independent bugs affecting wav and vorbis files that prevented them from being removed.

The developer of the tag library we use fixed these issues so I will update Tagger today with the fixes :)

nlogozzo commented 10 months ago

https://github.com/NickvisionApps/Tagger/releases/tag/2023.11.1

Will be available through flathub within the hour!