NickvisionApps / Tagger

Tag your music
https://flathub.org/apps/details/org.nickvision.tagger
MIT License
211 stars 13 forks source link

Crash when trying to load network folders #399

Closed bennypowers closed 8 months ago

bennypowers commented 8 months ago

Trying to load a folder over the network (mounted with sftp through nautilus) crashes Tagger. Here's the dump from journalctl -f

Nov 09 20:43:17 i systemd-coredump[63084]: [🡕] Process 62585 (NickvisionTagge) of user 1000 dumped core.

                                           Stack trace of thread 2:
                                           #0  0x00007fe555e91204 n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x91204)
                                           #1  0x00007fe555e3f04e n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x3f04e)
                                           #2  0x00007fe555e2888c n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x2888c)
                                           #3  0x00007fe4c6106e3e n/a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.6 + 0x23e3e)
                                           #4  0x00007fe4c6170f07 n/a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.6 + 0x8df07)
                                           #5  0x00007fa428960d27 n/a (/usr/lib/x86_64-linux-gnu/libgtk-4.so.1.1000.5 + 0x160d27)
                                           #6  0x00007fe4d9770396 n/a (n/a + 0x0)
                                           #7  0x00007fe4d9770147 n/a (n/a + 0x0)
                                           #8  0x00007fe4d976fc35 n/a (n/a + 0x0)
                                           #9  0x00007fe4d9768754 n/a (n/a + 0x0)
                                           #10 0x00007fe4c5ebaebb n/a (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7600.6 + 0xc2ebb)
                                           #11 0x00007fe4c5ebbcbb n/a (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7600.6 + 0xc3cbb)
                                           #12 0x00007fa428960a22 n/a (/usr/lib/x86_64-linux-gnu/libgtk-4.so.1.1000.5 + 0x160a22)
                                           #13 0x00007fe4c624ba28 n/a (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.7600.6 + 0x1aa28)
                                           #14 0x00007fe4c624965a n/a (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.7600.6 + 0x1865a)
                                           #15 0x00007fe4c626453f n/a (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.7600.6 + 0x3353f)
                                           #16 0x00007fe4c6264743 n/a (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.7600.6 + 0x33743)
                                           #17 0x00007fa428b14379 n/a (/usr/lib/x86_64-linux-gnu/libgtk-4.so.1.1000.5 + 0x314379)
                                           #18 0x00007fe4c5f14980 n/a (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7600.6 + 0x11c980)
                                           #19 0x00007fe4c6143e89 n/a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.6 + 0x60e89)
                                           #20 0x00007fe4c61443e8 n/a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.6 + 0x613e8)
                                           #21 0x00007fe4c6144483 n/a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.6 + 0x61483)
                                           #22 0x00007fe4c5eec36d n/a (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7600.6 + 0xf436d)
                                           #23 0x00007fe4d73ce699 n/a (n/a + 0x0)
                                           #24 0x00007fe4d73ce586 n/a (n/a + 0x0)
                                           #25 0x00007fe4d73ce49e n/a (n/a + 0x0)
                                           #26 0x00007fe4d73ce386 n/a (n/a + 0x0)
                                           #27 0x00007fe4d7370acf n/a (n/a + 0x0)
                                           #28 0x00007fe555ac3d47 n/a (/app/lib/org.nickvision.tagger/libcoreclr.so + 0x4c3d47)
                                           #29 0x00007fe5558f3394 n/a (/app/lib/org.nickvision.tagger/libcoreclr.so + 0x2f3394)
                                           #30 0x00007fe5557d604b n/a (/app/lib/org.nickvision.tagger/libcoreclr.so + 0x1d604b)
                                           #31 0x00007fe5557d639b n/a (/app/lib/org.nickvision.tagger/libcoreclr.so + 0x1d639b)
                                           #32 0x00007fe5558033c5 n/a (/app/lib/org.nickvision.tagger/libcoreclr.so + 0x2033c5)
                                           #33 0x00007fe555ca19b3 n/a (/app/lib/org.nickvision.tagger/libcoreclr.so + 0x6a19b3)
                                           #34 0x00007fe556143871 n/a (/app/lib/org.nickvision.tagger/libhostpolicy.so + 0x28871)
                                           #35 0x00007fe556143d01 n/a (/app/lib/org.nickvision.tagger/libhostpolicy.so + 0x28d01)
                                           #36 0x00007fe55614472c n/a (/app/lib/org.nickvision.tagger/libhostpolicy.so + 0x2972c)
                                           #37 0x00007fe55619dbe4 n/a (/app/lib/org.nickvision.tagger/libhostfxr.so + 0x25be4)
                                           #38 0x00007fe55619c309 n/a (/app/lib/org.nickvision.tagger/libhostfxr.so + 0x24309)
                                           #39 0x00007fe5561976db n/a (/app/lib/org.nickvision.tagger/libhostfxr.so + 0x1f6db)
                                           #40 0x000055a3704d84c5 n/a (/app/lib/org.nickvision.tagger/NickvisionTagger.GNOME + 0x184c5)
                                           #41 0x000055a3704d89a0 n/a (/app/lib/org.nickvision.tagger/NickvisionTagger.GNOME + 0x189a0)
                                           #42 0x00007fe555e2958a n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x2958a)
                                           #43 0x00007fe555e2964b n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x2964b)
                                           #44 0x000055a3704cc029 n/a (/app/lib/org.nickvision.tagger/NickvisionTagger.GNOME + 0xc029)
                                           ELF object binary architecture: AMD x86-64
nlogozzo commented 8 months ago

75 . Same applies to network drives.

Please use Flatseal to give Tagger full file system access and then restart the app and it should work.

bennypowers commented 8 months ago

@nlogozzo did not appear to help.

nlogozzo commented 8 months ago

Could you run the app via the terminal (flatpak run org.nickvision.tagger) and paste any errors when the app crashes here?

bennypowers commented 8 months ago
❯ flatpak run org.nickvision.tagger 

(NickvisionTagger.GNOME:2): Gtk-CRITICAL **: 22:21:03.401: gtk_widget_set_size_request: assertion 'width >= -1' failed
**
Gtk:ERROR:../gtk/gtkfiledialog.c:890:finish_file_op: assertion failed: (g_list_model_get_n_items (files) == 1)
Bail out! Gtk:ERROR:../gtk/gtkfiledialog.c:890:finish_file_op: assertion failed: (g_list_model_get_n_items (files) == 1)
nlogozzo commented 8 months ago

Hmm that's a new one...let me look into it

nlogozzo commented 8 months ago

Seems like this was a gtk bug: https://discourse.gnome.org/t/gtk-filedialog-crashes-with-the-application-when-selecting-a-cloud-directory/16619

I will update the gtk runtime in flatpak and hopefully that will contain the fix.

nlogozzo commented 8 months ago

@bennypowers You can download the flatpak file from this build: https://github.com/NickvisionApps/Tagger/actions/runs/6820386380

You can install it by running flatpak install org.nickvision.tagger.flatpak in the directory of which you extracted the file. Then run it by using flatpak run org.nickvision.tagger//master and after testing you can uninstall it with flatpak uninstall org.nickvision.tagger//master

This will not affect your main flatpak installation of Tagger

bennypowers commented 8 months ago
❯ flatpak run org.nickvision.tagger//master

(NickvisionTagger.GNOME:2): Gtk-CRITICAL **: 07:43:02.903: gtk_widget_set_size_request: assertion 'width >= -1' failed

Progress! No crash, but no change in UI after loading a folder

image

nlogozzo commented 8 months ago

but no change in UI after loading a folder

@bennypowers Is this after opening any folder (i.e. Downloads) or just the network folders?

Could you try rebooting and running flatpak run org.nickvision.tagger//master again and see what happens.

bennypowers commented 8 months ago

I did:

  1. reboot
  2. flatpak run org.nickvision.tagger//master
  3. see width >= 1 assertion fail in console,
  4. see tagger window opens
  5. open folder ~/Music/* (local)
  6. see files
  7. close tagger
  8. run flatpak run org.nickvision.tagger//master
  9. add network folder as above
  10. see no error in terminal
  11. see no change in ui

journalctl entries for step 9 above


Nov 10 08:18:40 i xdg-desktop-por[4654]: g_path_get_basename: assertion 'file_name != NULL' failed
Nov 10 08:18:40 i xdg-desktop-por[4654]: g_path_get_dirname: assertion 'file_name != NULL' failed
Nov 10 08:18:40 i xdg-desktop-por[4654]: Failed to register sftp://redacted@redacted/var/home/redacted/Music: Failed to open sftp://redacted@redacted/var/home/redacted/Music
nlogozzo commented 8 months ago

journalctl entries for step 9 above


Nov 10 08:18:40 i xdg-desktop-por[4654]: g_path_get_basename: assertion 'file_name != NULL' failed
Nov 10 08:18:40 i xdg-desktop-por[4654]: g_path_get_dirname: assertion 'file_name != NULL' failed
Nov 10 08:18:40 i xdg-desktop-por[4654]: Failed to register sftp://redacted@redacted/var/home/redacted/Music: Failed to open sftp://redacted@redacted/var/home/redacted/Music

This is a portal issue now: https://github.com/flatpak/xdg-desktop-portal/issues/820

Nothing we can do on our end...just need to wait for it to be fixed and the portal to be updated on your system.

nlogozzo commented 8 months ago

A temporary solution...which sucks and is a bad solution but again nothing we can do....is copy the files off your network drive into your local music folder...open Tagger there, edit them, and then move them back to your network drive.

nlogozzo commented 8 months ago

The stable version is here with the updated gtk version: https://github.com/NickvisionApps/Tagger/releases/2023.11.2

So at least you can run that and it won't crash

bennypowers commented 8 months ago

I've confirmed that stable doesn't crash and doesn't load

I will be able to run tagger directly on the NAS, so i'm not blocked.

Thank you for looking into this