NickvisionApps / Tagger

Tag your music
https://flathub.org/apps/details/org.nickvision.tagger
MIT License
226 stars 14 forks source link

vorbis: allow multiple genre tags for flac #402

Closed dfrein closed 10 months ago

dfrein commented 11 months ago

vorbis format specification allows that tags / fields are not unique, but can be used more than one time, e.g. for artists or genres. This represents the recommended way to store multiple fields with multiple values. Currently, tagger (22.11.1) joins / concatenates such existing multiple tags in flac files into one field, which gives problems with some software. It would be good if tagger could support multiple fields with the same name, or at least does not touch existing multiple flac tags like artist or genre.

nlogozzo commented 11 months ago

Currently, tagger (22.11.1) joins / concatenates such existing multiple tags in flac files into one field, which gives problems with some software.

I've never had experience with flac files that have multiple values per field. And since we use an external backend for our tagging system, I'm not sure how it handles it either.

When you say Tagger joins these values together, what does it do? Does it separate them with ; or something?

dfrein commented 11 months ago

Thank you for your explanation. In my case I tag the flac files myself this way, as this seems to be the recommended method for multiple genres for the logitech media server / the squeezebox streaming platform. And yes, tagger joins existing genre tags, separated with ;.

nlogozzo commented 11 months ago

In my case I tag the flac files myself this way, as this seems to be the recommended method for multiple genres for the logitech media server / the squeezebox streaming platform

Which is fine...

And yes, tagger joins existing genre tags, separated with ;

So what's wrong with continuing to separate values of a field with ;?

which gives problems with some software

What are the problems seen in the other software? Tagger should display the multiple values as one separated by ; and then when you add more values with ;, in the backend it should separate them back out into a list and store it in the file appropriately.

dfrein commented 11 months ago

I had just fears that other software could be irritated by this, and sorting / filtering by genre (or artist) would not work as expected. But I just checked again with the most recent development version of logitech media server which (now?) seems also able to understand the delimiter ;, so this seems not to be an issue for my use case, but rather a wish, to allow tagging with different software like kid3 in parallel.

nlogozzo commented 11 months ago

Well like I said the fact that Tagger joins the values together with ; is purely for display purposes. When the tag gets saved back to the file it's saved as a proper list as the tag format supports.

Could you try opening said file in kid3? There should be no issue...

This is common-practice for most tagging software.

If there are any issues opening in kid3, then please email me the file you are tagging at nlogozzo225@gmail.com and I will pass it along to the library's developer that we use for fixing and improving.

dfrein commented 11 months ago

Thanks, there is mo real issue with kid3, it's just that I cannot use the pulldown list there for genres there in a meaningful way, as I first have to split up the existing genres again (but I have to check if there is some way to do that automatically in kid3). Because I have a list of the genres I usually use and I prefer it this way. Probably I should just change my workflow...