search

NickvisionApps / Tagger

Tag your music
https://flathub.org/apps/details/org.nickvision.tagger
MIT License
211 stars 13 forks source link

Temporary storage for network file editing #417

Open Morethanevil opened 7 months ago

Morethanevil commented 7 months ago

First, thanks for this easy to use and powerful tagger. It was a missing piece since I migrated to Linux. A very good MP3Tag-replacement and it works with FLAC too :)

I wanted to edit my files on my Ubuntu homeserver. On my desktop, I use Fedora 39 KDE and installed tagger via flatpak. Latest version is 2023.11.3. I granted all system files access, mentioned in this similar issue. It does not crash, but it takes about 5 minutes for 4 files.

I tried to copy over these FLAC to my system and edit them directly. 35 Files in 6 seconds.

It does not matter if I only want to edit artist or track, or if I want to add covers...

nlogozzo commented 7 months ago

That's just the nature of network mounts unfortunately :/

I tried to copy over these FLAC to my system and edit them directly. 35 Files in 6 seconds.

this would be my recommendation as bad as it is...

Another thing you could try is installing Tagger from source, you can look at the AUR package, instead of running from flatpak which my add a slowdown as it needs to "portalize" the network mount.

Morethanevil commented 7 months ago

Is there a way to add a "tmp -dir" solution? Tagger will create a small tmp directory, copy x MB over, modifies the file and writes them back. This way it could be more responsive. Would be a "workaround"

nlogozzo commented 7 months ago

We could definitely implement that, however, we would need a robust API that detects network drives/stores over regular local files.

I will look into this

Morethanevil commented 7 months ago

Thanks :)

nlogozzo commented 6 months ago

@Morethanevil How long does it take you to copy the files from the network share to a local location?

I feel like Tagger going through the process of lets say someone opening a folder with 100 files, copying them to a temp dir, and uploading them back on save will take the same time as Tagger does now editing the files directly off the share...

Any input on this feature? @DaPigGuy

Morethanevil commented 6 months ago

It does not take long, I have 2,5Gbit LAN 😅

How about caching the files before saving?

Edit a file, press save, tagger makes a copy to temp, saves and writes back. Should be quick imo

Or caching when opening a folder. 100 files with 4MB size take around 6 minutes with gigabit LAN for caching 🤔