Nicky-Nie / PM566-Labs

0 stars 1 forks source link

Fixing RawGit issue #1

Open AbigailHorn opened 2 years ago

AbigailHorn commented 2 years ago

https://github.com/Nicky-Nie/PM566-Labs/blob/e74175fdc4cec062c24ee1910501fa06de4f33b9/Lab_11/README.Rmd#L108

Hi @Nicky-Nie , I took a look at your Lab_11/README.Rmd and needed to add the following line of code just before line 108 to get it to compile: state_list = unique(cv_states$state). This was because you read in the data using a different command than I had (I used data.table::fread() and you used read.csv(). The different methods of data read in had different structured variables and so the unique state list didn't match up. This one line of code should fix that and allow the code to compile. Once you've compiled it, and confirmed the figures come out in the html version, then push the code, and repeat the same steps with RawGit to get the html figure-visible link you need.

After I complied the doc with the line fix above, I was able to show the interactive plots in the RawGit link here: https://github.com/AbigailHorn/PM566-labs/tree/master/students

So it should work. Let me know once you've done that and I'll take a look.

AbigailHorn commented 2 years ago

I also saw the problem is fixed if you replace the "main" with "master" in your url: i.e., https://ghcdn.rawgit.org/Nicky-Nie/PM566-Labs/master/Lab_11/README.html should render all of the plots!

Nicky-Nie commented 2 years ago

Thank you!

It seems that adding one line before 108 line not work very well but change main into master really helps a lot!

And it seems that we will have a due this Friday but there is no issue we can upload assignment04 :)

2021年11月15日 下午10:51,Abigail Horn @.***> 写道:

I also saw the problem is fixed if you replace the "main" with "master" in your url: i.e., https://ghcdn.rawgit.org/Nicky-Nie/PM566-Labs/master/Lab_11/README.html https://ghcdn.rawgit.org/Nicky-Nie/PM566-Labs/master/Lab_11/README.html should render all of the plots!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Nicky-Nie/PM566-Labs/issues/1#issuecomment-969928827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVLWQIXNUAZJDLXAIOCAY3LUMH5OZANCNFSM5IDJM4MA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

AbigailHorn commented 2 years ago

Glad that worked for your lab-11, and thanks for the note about the issue for this week + assignment 4! Please see here to submit: https://github.com/USCbiostats/PM566/issues/49

See you tomorrow!