search

NickyMeuleman / nicky-blog

https://nickymeuleman.netlify.app/
14 stars 6 forks source link

Move off reach-ui #165

Closed NickyMeuleman closed 5 days ago

NickyMeuleman commented 2 years ago

https://github.com/reach/reach-ui/issues/972

Specifically @reach/tabs and @reach/tooltip

Edit: I want to make clear @chaance is awesome. (And he's the reason for my blogposts have that <details> element to the side btw, still love that)

NickyMeuleman commented 2 years ago

alternative: do nothing and wait until @reach/tabs is React 18 compatible https://github.com/reach/reach-ui/issues/972#issuecomment-1275497222

chaance commented 2 years ago

FWIW I do think I'm close on getting descendants working for React 18, which is the only holdup for Tabs. Tooltip is probably fine, but we do some DOM manipulation in effects that concerns me considering StrictMode will run those effects twice. I think those are also probably fine, they just need a good review when I have time.

NickyMeuleman commented 5 days ago

closing all issues before complete rewrite