search

NiclasOlofsson / MiNET

A (not so) basic Minecraft Pocket Edition server written in C#
Other
869 stars 200 forks source link

Changes 1.19.xx #637

Closed TheFirewall closed 1 year ago

TheFirewall commented 1 year ago

TODO:

TheFirewall commented 1 year ago

Judging by the tests, everything is fine, the only thing that causes concern is a bug in MINET.Client, judging by the protocol, everything should be fine.

System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at MiNET.Utils.IO.MemoryStreamReader.ReadByte() in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Utils\IO\MemoryStreamReader.cs:line 83
   at MiNET.Net.Packet.ReadBool() in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Net\Packet.cs:line 109
   at MiNET.Net.Packet.ReadEntityLink() in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Net\Packet.cs:line 2284
   at MiNET.Net.Packet.ReadEntityLinks() in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Net\Packet.cs:line 2310
   at MiNET.Net.McpeAddPlayer.DecodePacket() in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Net\MCPE Protocol.cs:line 2616
   at MiNET.Net.Packet.Decode(ReadOnlyMemory`1 buffer) in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Net\Packet.cs:line 3752
   at MiNET.Net.PacketFactory.Create(Byte messageId, ReadOnlyMemory`1 buffer, String ns) in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Net\MCPE Protocol.cs:line 740
   at MiNET.Net.BedrockMessageHandlerBase.HandlePacket(Packet message) in C:\Users\twwkm\source\repos\NiclasOlofsson\MiNET\src\MiNET\MiNET\Net\BedrockMessageHandlerBase.cs:line 177