search

NicoHood / GPGit

A shell script that automates the process of signing Git sources via GPG
MIT License
89 stars 10 forks source link

Fix pylint warnings #7

Closed NicoHood closed 6 years ago

NicoHood commented 7 years ago

There are some pylint warnings that needs to be understood and fixed. Most are already fixed.

From 2.0.4:

$ pylint gpgit.py 
No config file found, using default configuration
************* Module gpgit
W:114, 0: TODO add elliptic curve support (fixme)
W:274, 0: TODO Will associate your GPG key with Github (fixme)
W:284, 0: TODO cannot catch error for unknown GPG key as its run in a separat thread (fixme)
W:308, 0: TODO (fixme)
W:371, 0: TODO not working for repository (local) setting as config group does not yet exist (fixme)
W:372, 0: TODO also fix above? (fixme)
W:408, 0: TODO catch missing exception https://github.com/gitpython-developers/GitPython/issues/621 (fixme)
W:583, 0: TODO v 2.x GPG module (fixme)
W:587, 0: TODO https://tools.ietf.org/html/rfc4880#section-9.4 (fixme)
W:662, 0: TODO improve exception: (fixme)
W:671, 0: TODO improve: (fixme)
W:717, 0: TODO not functional (fixme)
W:784, 0: TODO set to the fp once the key was checked once to speed things up (fixme)
W:842, 0: TODO fix for projects that dont have a Github url (fixme)
W:953, 0: TODO more colors with green arrow (fixme)
C:208, 0: Line too long (150/100) (line-too-long)
C:784, 0: Line too long (118/100) (line-too-long)
C: 30, 4: Missing function docstring (missing-docstring)
C: 40, 0: Missing class docstring (missing-docstring)
R: 40, 0: Too few public methods (0/2) (too-few-public-methods)
R: 66, 0: Too few public methods (0/2) (too-few-public-methods)
R:128, 4: Too many return statements (7/6) (too-many-return-statements)
R:128, 4: Too many branches (18/12) (too-many-branches)
R:439, 4: Too many local variables (18/15) (too-many-locals)
W:515,50: Cell variable filestream defined in loop (cell-var-from-loop)
R:439, 4: Too many return statements (7/6) (too-many-return-statements)
R:439, 4: Too many branches (20/12) (too-many-branches)
W:609,54: Cell variable filestream defined in loop (cell-var-from-loop)
C:618, 0: Missing class docstring (missing-docstring)
R:721, 0: Too many instance attributes (10/7) (too-many-instance-attributes)
E:799,47: Instance of 'GitConfigParser' has no 'has_option' member (no-member)
E:817,25: Instance of 'GPGit' has no 'version' member (no-member)

------------------------------------------------------------------
Your code has been rated at 9.21/10 (previous run: 9.44/10, -0.23)
NicoHood commented 6 years ago

Closing as I switched back to bash. I dont know if I will use the python version again, bash seems still simpler to code and easier to install.