search

NicoHood / Nintendo

Use Nintendo Controllers with Arduino
http://www.nicohood.de
MIT License
283 stars 56 forks source link

Fix bug in N64 API #28

Closed moparisthebest closed 3 years ago

moparisthebest commented 3 years ago

The N64 API did not work, and upon further inspection, it was calling gc_init instead of n64_init, this fixes that, and the API works now! (on a Arduino Pro Micro clone with a voltage converter, in my case)

edit: here is how I use+tested it

NicoHood commented 3 years ago

Hmmmm interesting that nobody found this issue. I guess everybody is using the Gamecube code. I dont see any reason why your patch should not be correct, but I am still confused, as this is a fundamental bug...

Looking at the code, it seems to does not make any difference: https://github.com/NicoHood/Nintendo/blob/master/src/Gamecube.c#L30-L43 https://github.com/NicoHood/Nintendo/blob/master/src/N64.c#L30-L42

Even the response is idential: https://github.com/NicoHood/Nintendo/blob/master/src/N64.h#L87

So you patch is still correct, but I dont think it fixes any issue. Correct me if I am wrong (I possibly am).

NicoHood commented 3 years ago

@JonnyHaystack can you maybe also have a look at this PR?

JonnyHaystack commented 3 years ago

I actually looked at this a while ago and came to the same conclusion as you. No idea why it would make a difference but it fixes the typos at least. I didn't need it for mine.