Open blueOkiris opened 5 months ago
There is only one path of return for the N64 Console Write function and it's a return false:
return false
https://github.com/NicoHood/Nintendo/blob/e4130ff38039f125d94c5aee7469724dd2965a56/src/N64API.hpp#L165-L186
It will always say it failed to write controller data to console!
I would implement the fix myself and post a PR, but I'm not entirely certain what the correct behavior should be.
I'm assuming it should be similar to CGamecubeConsole::write, but it wouldn't be exactly the same, right?
CGamecubeConsole::write
https://github.com/NicoHood/Nintendo/blob/e4130ff38039f125d94c5aee7469724dd2965a56/src/GamecubeAPI.hpp#L231-L243
I suppose I'm assuming that it shouldn't always return false, but perhaps that's the intended behavior or it shouldn't return anything and that was left over, but I figured it was worth asking if not
There is only one path of return for the N64 Console Write function and it's a
return false
:https://github.com/NicoHood/Nintendo/blob/e4130ff38039f125d94c5aee7469724dd2965a56/src/N64API.hpp#L165-L186
It will always say it failed to write controller data to console!
I would implement the fix myself and post a PR, but I'm not entirely certain what the correct behavior should be.
I'm assuming it should be similar to
CGamecubeConsole::write
, but it wouldn't be exactly the same, right?https://github.com/NicoHood/Nintendo/blob/e4130ff38039f125d94c5aee7469724dd2965a56/src/GamecubeAPI.hpp#L231-L243
I suppose I'm assuming that it shouldn't always return false, but perhaps that's the intended behavior or it shouldn't return anything and that was left over, but I figured it was worth asking if not