NicoNekoDev / AstralBooks

Github repository of CitizensBooks.
https://www.spigotmc.org/resources/citizensbooks.37465/
Apache License 2.0
9 stars 3 forks source link

[Bug] Books don't stay on blocks through server restarts #47

Closed maskreet closed 1 year ago

maskreet commented 1 year ago

Information

Full output of /abook about: <+ AstralBooks +> Version: 3.0.4 Auhtor: NicoNekoDev Server log (upload logs/latest.log to Gist): https://gist.github.com/maskreet/5adcbbc23dfe8afedc8bcdb3d75ad3ea AstralBooks config (upload plugins/AstralBooks/config.yml to Gist): https://gist.github.com/maskreet/bf19986237e934bb44a3e68fba274bed

Details

Whenever I place a book on a block or entity, the book disappears from either once I restart the server.

Commands in-game I've used are: /abook interaction set block/entity right/left

I'd thought it was something with WorldGuard, but I tried it in a non-WG region, and it does the same thing.

Using Spigot 1.20.1

NicoNekoDev commented 1 year ago

If you previously had set the interaction books on some blocks, now after restart, every block you set should show up. Thank you for the report! :)

maskreet commented 1 year ago

Nope, they disappear from the blocks or entities after a server restart every time.

They work perfectly while the server is still up, but as soon as I restart it and try and get the book to show on clicking the block or entity, nothing happens or the default happen (right-clicking on a sign brings up the editor for the sign).

On Sat, Sep 9, 2023, 4:13 PM Drăghiciu Nicolae @.***> wrote:

If you previously had set the interaction books on some blocks, now after restart, every block you set should show up. Thank you for the report! :)

— Reply to this email directly, view it on GitHub https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712592192, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TV57FL3OK6WSQRRVOTXZTEWLANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

NicoNekoDev commented 1 year ago

Did you try the latest version?

maskreet commented 1 year ago

Not yet, looks like you released a new version an hour ago. I installed the new one remotely, I'll let you know when I get out of work tonight if the block or entity thing persists after a server restart.

On Sat, Sep 9, 2023, 4:46 PM Drăghiciu Nicolae @.***> wrote:

Did you try the latest version?

— Reply to this email directly, view it on GitHub https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712597817, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TUEPATARPJPV5T7US3XZTISXANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

maskreet commented 1 year ago

This is the error I'm getting using h2 storage:

pool-55-thread-1/WARN 23:55:30

[AstralBooks]: (H2) Failed to save book data!

Console 23:55:30

org.h2.jdbc.JdbcSQLDataException: Invalid value "5" for parameter "parameterIndex" [90008-214] at org.h2.message.DbException.getJdbcSQLException(DbException.java:646) ~[?:?] at org.h2.message.DbException.getJdbcSQLException(DbException.java:477) ~[?:?] at org.h2.message.DbException.get(DbException.java:223) ~[?:?] at org.h2.message.DbException.getInvalidValueException(DbException.java:298) ~[?:?] at org.h2.jdbc.JdbcPreparedStatement.setParameter(JdbcPreparedStatement.java:1395) ~[?:?] at org.h2.jdbc.JdbcPreparedStatement.setString(JdbcPreparedStatement.java:378) ~[?:?] at ro.niconeko.astralbooks.storage.types.impl.H2Storage.lambda$putNPCBookStack$6(H2Storage.java:218) ~[?:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?]

I switched to sqlite and converted and it seems to be working now 100%. I lost a couple books in the filter list, but I just added them back. Thank you so much, man!

On Sat, Sep 9, 2023 at 5:32 PM maskreet @.***> wrote:

Not yet, looks like you released a new version an hour ago. I installed the new one remotely, I'll let you know when I get out of work tonight if the block or entity thing persists after a server restart.

On Sat, Sep 9, 2023, 4:46 PM Drăghiciu Nicolae @.***> wrote:

Did you try the latest version?

— Reply to this email directly, view it on GitHub https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712597817, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TUEPATARPJPV5T7US3XZTISXANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

NicoNekoDev commented 1 year ago

Oops. Fixed that too now. Sorry for that!

maskreet commented 1 year ago

It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before.

On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae @.***> wrote:

Oops. Fixed that too now. Sorry for that!

— Reply to this email directly, view it on GitHub https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712722096, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

maskreet commented 1 year ago

Just noticed now too that when I go to apply a book to a block, it shows on right-click just fine, but only while the book is in my inventory. And yes, I made sure it wasn't being held when interacting with the block. =) Placing the original book into a container and trying again doesn't show a book on the block.

On Mon, Sep 11, 2023 at 1:29 PM maskreet @.***> wrote:

It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before.

On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae < @.***> wrote:

Oops. Fixed that too now. Sorry for that!

— Reply to this email directly, view it on GitHub https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712722096, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

NicoNekoDev commented 1 year ago

Just noticed now too that when I go to apply a book to a block, it shows on right-click just fine, but only while the book is in my inventory. And yes, I made sure it wasn't being held when interacting with the block. =) Placing the original book into a container and trying again doesn't show a book on the block. On Mon, Sep 11, 2023 at 1:29 PM maskreet @.> wrote: It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae < @.> wrote: > Oops. Fixed that too now. Sorry for that! > > — > Reply to this email directly, view it on GitHub > <#47 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY > . > You are receiving this because you authored the thread.Message ID: > @.***> >

The book needs to be in your hand only when the command is executed, after that you just right click apply with whatever you want in your hand. It's per player memory saved for 10 seconds after that you need to execute the command again to get it to work.

It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae @.> wrote: Oops. Fixed that too now. Sorry for that! — Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.>

I'm gonna take a look when I'll have time. Thanks again for reporting. Edit: please make sure that your inventory is clear or there aren't any errors in the console. The book mostly goes into the inventory, so that's that.

maskreet commented 1 year ago

No worries! Here's the error that shows when I try to interact with a block that has a book applied to it, but after I place the original book into a chest. I also figured out switching from sqlite back to h2 storage made using the "filter getbook" command to work again.

23:01:42

Could not pass event PlayerInteractEvent to AstralBooks v3.0.6

Console 23:01:42

org.bukkit.event.EventException: null at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:566) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.level.PlayerInteractManager.a(PlayerInteractManager.java:503) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1642) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:37) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.TickTask.run(SourceFile:18) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:156) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1151) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.x(SourceFile:130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.bg(MinecraftServer.java:1130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1123) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.c(SourceFile:139) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.p(MinecraftServer.java:1107) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1018) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:303) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.IllegalArgumentException: The ItemStack is not a written book! This is not an error with AstralBooks, so please don't report it. Make sure the plugins that uses AstralBooks as dependency are correctly configured. at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) ~[guava-31.1-jre.jar:?] at ro.niconeko.astralbooks.AstralBooksCore.openBook(AstralBooksCore.java:362) ~[?:?] at ro.niconeko.astralbooks.listeners.PlayerActions.onInteract(PlayerActions.java:180) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor153.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] ... 22 more

On Mon, Sep 11, 2023 at 4:08 PM Drăghiciu Nicolae @.***> wrote:

Just noticed now too that when I go to apply a book to a block, it shows on right-click just fine, but only while the book is in my inventory. And yes, I made sure it wasn't being held when interacting with the block. =) Placing the original book into a container and trying again doesn't show a book on the block. … <#m-2814745588963251681> On Mon, Sep 11, 2023 at 1:29 PM maskreet @.> wrote: It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae < @.> wrote: > Oops. Fixed that too now. Sorry for that! > > — > Reply to this email directly, view it on GitHub > <#47 (comment) https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712722096>,

or unsubscribe > https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . > You are receiving this because you authored the thread.Message ID: > @.***> >

The book needs to be in your hand only when the command is executed, after that you just right click apply with whatever you want in your hand. It's per player memory saved for 10 seconds after that you need to execute the command again to get it to work.

It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. … <#m-2814745588963251681> On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae @.> wrote: Oops. Fixed that too now. Sorry for that! — Reply to this email directly, view it on GitHub <#47 (comment) https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712722096>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.>

I'm gonna take a look when I'll have time. Thanks again for reporting.

— Reply to this email directly, view it on GitHub https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1714507056, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TQOBWAQDGL26S6WZ53XZ5VTHANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

NicoNekoDev commented 1 year ago

No worries! Here's the error that shows when I try to interact with a block that has a book applied to it, but after I place the original book into a chest. I also figured out switching from sqlite back to h2 storage made using the "filter getbook" command to work again. 23:01:42 Could not pass event PlayerInteractEvent to AstralBooks v3.0.6 Console 23:01:42 org.bukkit.event.EventException: null at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:566) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.level.PlayerInteractManager.a(PlayerInteractManager.java:503) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1642) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:37) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.TickTask.run(SourceFile:18) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:156) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1151) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.x(SourceFile:130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.bg(MinecraftServer.java:1130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1123) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.c(SourceFile:139) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.p(MinecraftServer.java:1107) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1018) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:303) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.IllegalArgumentException: The ItemStack is not a written book! This is not an error with AstralBooks, so please don't report it. Make sure the plugins that uses AstralBooks as dependency are correctly configured. at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) ~[guava-31.1-jre.jar:?] at ro.niconeko.astralbooks.AstralBooksCore.openBook(AstralBooksCore.java:362) ~[?:?] at ro.niconeko.astralbooks.listeners.PlayerActions.onInteract(PlayerActions.java:180) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor153.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] ... 22 more On Mon, Sep 11, 2023 at 4:08 PM Drăghiciu Nicolae @.> wrote: Just noticed now too that when I go to apply a book to a block, it shows on right-click just fine, but only while the book is in my inventory. And yes, I made sure it wasn't being held when interacting with the block. =) Placing the original book into a container and trying again doesn't show a book on the block. … <#m-2814745588963251681> On Mon, Sep 11, 2023 at 1:29 PM maskreet @.> wrote: It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae < @.> wrote: > Oops. Fixed that too now. Sorry for that! > > — > Reply to this email directly, view it on GitHub > <#47 (comment) <#47 (comment)>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY > . > You are receiving this because you authored the thread.Message ID: > @.> > The book needs to be in your hand only when the command is executed, after that you just right click apply with whatever you want in your hand. It's per player memory saved for 10 seconds after that you need to execute the command again to get it to work. It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. … <#m-2814745588963251681> On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae @.> wrote: Oops. Fixed that too now. Sorry for that! — Reply to this email directly, view it on GitHub <#47 (comment) <#47 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.> I'm gonna take a look when I'll have time. Thanks again for reporting. — Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TQOBWAQDGL26S6WZ53XZ5VTHANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

I don't get it how did you set another item type other than a written book. Guess I'll add more checks. Have you tried to set the book again on the block?

maskreet commented 1 year ago

I did, and it did the same thing. I had an idea that if it wasn't in the original position of the hotbar it would break being able to see the interaction set on the block and I was right. Just moving it to another part of the hotbar or even in the Survival inventory breaks being able to bring up the book on the block again. Here's the new error message:

13:51:10

maskreet issued server command: /abook interaction set block right

Console 13:51:18

at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] ... 22 more

Server thread/ERROR 13:51:22

Could not pass event PlayerInteractEvent to AstralBooks v3.0.6

Console 13:51:22

org.bukkit.event.EventException: null at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:566) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.level.PlayerInteractManager.a(PlayerInteractManager.java:503) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1642) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:37) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.TickTask.run(SourceFile:18) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:156) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1151) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.util.thread.IAsyncTaskHandler.x(SourceFile:130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.MinecraftServer.bg(MinecraftServer.java:1130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1123) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.util.thread.IAsyncTaskHandler.c(SourceFile:139) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.MinecraftServer.p(MinecraftServer.java:1107) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1018) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:303) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3870-Spigot-d2eba2c-78796c9] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.IllegalArgumentException: The ItemStack is not a written book! This is not an error with AstralBooks, so please don't report it. Make sure the plugins that uses AstralBooks as dependency are correctly configured. at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) ~[guava-31.1-jre.jar:?] at ro.niconeko.astralbooks.AstralBooksCore.openBook(AstralBooksCore.java:362) ~[?:?] at ro.niconeko.astralbooks.listeners.PlayerActions.onInteract(PlayerActions.java:180) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] ... 22 more

On Tue, Sep 12, 2023 at 5:09 AM Drăghiciu Nicolae @.***> wrote:

No worries! Here's the error that shows when I try to interact with a block that has a book applied to it, but after I place the original book into a chest. I also figured out switching from sqlite back to h2 storage made using the "filter getbook" command to work again. 23:01:42 Could not pass event PlayerInteractEvent to AstralBooks v3.0.6 Console 23:01:42 org.bukkit.event.EventException: null at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:566) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.level.PlayerInteractManager.a(PlayerInteractManager.java:503) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1642) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:37) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.TickTask.run(SourceFile:18) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:156) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1151) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.x(SourceFile:130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.bg(MinecraftServer.java:1130) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1123) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.util.thread.IAsyncTaskHandler.c(SourceFile:139) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.p(MinecraftServer.java:1107) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1018) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:303) ~[spigot-1.20.1-R0.1-SNAPSHOT.jar:3864-Spigot-d2eba2c-00f5a80] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.IllegalArgumentException: The ItemStack is not a written book! This is not an error with AstralBooks, so please don't report it. Make sure the plugins that uses AstralBooks as dependency are correctly configured. at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) ~[guava-31.1-jre.jar:?] at ro.niconeko.astralbooks.AstralBooksCore.openBook(AstralBooksCore.java:362) ~[?:?] at ro.niconeko.astralbooks.listeners.PlayerActions.onInteract(PlayerActions.java:180) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor153.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.20.1-R0.1-SNAPSHOT.jar:?] ... 22 more On Mon, Sep 11, 2023 at 4:08 PM Drăghiciu Nicolae @.

*> wrote: … <#m5795238038097262705> Just noticed now too that when I go to apply a book to a block, it shows on right-click just fine, but only while the book is in my inventory. And yes, I made sure it wasn't being held when interacting with the block. =) Placing the original book into a container and trying again doesn't show a book on the block. … <#m-2814745588963251681> On Mon, Sep 11, 2023 at 1:29 PM maskreet @.> wrote: It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook " gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae < @.> wrote: > Oops. Fixed that too now. Sorry for that! > > — > Reply to this email directly, view it on GitHub > <#47 https://github.com/NicoNekoDev/AstralBooks/issues/47 (comment) <#47 (comment) https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1712722096>>,

or unsubscribe > https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . > You are receiving this because you authored the thread.Message ID: > @.**> > The book needs to be in your hand only when the command is executed, after that you just right click apply with whatever you want in your hand. It's per player memory saved for 10 seconds after that you need to execute the command again to get it to work. It's cool, thank you for the quick fixes. I noticed also that now using "abook filter getbook

" gives the message that I received the book in my inventory, but nothing shows in my inventory. It was working before. … <#m_-2814745588963251681_> On Sun, Sep 10, 2023 at 1:47 AM Drăghiciu Nicolae @.> wrote: Oops. Fixed that too now. Sorry for that! — Reply to this email directly, view it on GitHub <#47 (comment) <#47 (comment) >>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY https://github.com/notifications/unsubscribe-auth/ACF37TTXLJQFBPBZIJIR4NTXZVH6HANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.*> I'm gonna take a look when I'll have time. Thanks again for reporting. — Reply to this email directly, view it on GitHub <#47 (comment) >, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TQOBWAQDGL26S6WZ53XZ5VTHANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: *@* .***>

I don't get it how did you set another item type other than a written book. Guess I'll add more checks. Have you tried to set the book again on the block?

— Reply to this email directly, view it on GitHub https://github.com/NicoNekoDev/AstralBooks/issues/47#issuecomment-1715321303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF37TSUVWW62VOOTHQU2QTX2AREBANCNFSM6AAAAAA4RSFAXY . You are receiving this because you authored the thread.Message ID: @.***>

NicoNekoDev commented 1 year ago

Yeah, by the looks of it, the book gets replace with Material.AIR... I need to do a copy of the itemstack instead when I'm memory saving it. Will fix as fast as possible.

NicoNekoDev commented 1 year ago

Well, after more debugging, I couldn't really replicate your issue. Somehow your block didn't set up correctly and I'm not really sure how that error came up. Might do some sanity checks, but that's all I can do. 🤷‍♂️