NicoNekoru / obsidan-advanced-table-xt

Plugin that adds features to tables in obsidian including merging, vertical headers, and custom css
Apache License 2.0
93 stars 3 forks source link

fix: temporarily fix inline TeX rendering issue #7 #9

Closed abiriadev closed 1 year ago

abiriadev commented 1 year ago

fix #7

Changes

Although it works as expected, it blinks too frequently, and I'm not sure why this is happening.

This is a temporary workaround. I believe there's a better approach to address the issue.

abiriadev commented 1 year ago

Results from testing on my vault:

https://github.com/NicoNekoru/obsidan-advanced-table-xt/assets/72962900/9fe2614e-131c-4bd8-b618-309569e4ad36

abiriadev commented 1 year ago

Probably this is where the blinking occurs?

https://github.com/NicoNekoru/obsidan-advanced-table-xt/blob/acdac5740a41f252c079b673a8258543e6d30f7d/src/sheetElement.ts#L326-L334

NicoNekoru commented 1 year ago

Probably this is where the blinking occurs?

https://github.com/NicoNekoru/obsidan-advanced-table-xt/blob/acdac5740a41f252c079b673a8258543e6d30f7d/src/sheetElement.ts#L326-L334

Yeah I used this jank solution to avoid disallowed markdown in the cells (anything that requires the start of a line like headings, ordered/unordered lists, etc.) which also really only exists because I am using Obsidian's default markdown renderer. I am probably going to migrate to showdown which would fix the blinking problem among some others.

NicoNekoru commented 1 year ago

This fix is exactly what I was looking for a while ago; thank you for introducing me to ctx.getSectionInfo