search

NicolaDonelli / py4ai-core

MIT License
0 stars 0 forks source link

[ISSUE-17] Substitute setup.cfg with pyproject.toml #18

Closed NicolaDonelli closed 2 years ago

NicolaDonelli commented 2 years ago

Closes #17

NicolaDonelli commented 2 years ago

@deusebio I cannot replicate on my local the mypy error that breaks the checks, thus I suspect it is due to the unbuntu-latest image... could you please check if on your ubuntu local the make mypy command actually works fine or not?

deusebio commented 2 years ago

In my local, it works on 3.10 but breaks on 3.9. (Could it be the python version rather than the OS?)

One of the reasons, why we did not switch to TOML is that the landscape was not yet ready a few months ago. Could it be the reason why older versions of python do not seem to work properly? I have not looked into this, just speculating here. But for sure, the failures applied to ubuntu 20.04 (tested in CI) and ubuntu 22.04 (testing in my local)

NicolaDonelli commented 2 years ago

It actually could had been a matter of python version, but now it seems I solved it (tweaking a bit the usage of mypy).

deusebio commented 2 years ago

Good to go!

NicolaDonelli commented 2 years ago

Ok, I rebased on the main branch to incorporate changes introduced by PR #7 #9 and #10, please let me know if it is allright or there is something to change before merging on main.

deusebio commented 2 years ago

I believe I had already approved