search

NicolaDonelli / py4ai-core

MIT License
0 stars 0 forks source link

[ISSUE-32] Refactor Dockerfile #34

Closed NicolaDonelli closed 1 year ago

NicolaDonelli commented 1 year ago

Close #32

deusebio commented 1 year ago

Let's first resolve the two disagreements on:

  1. Having .git folder in
  2. Two-stage build

in the related issues (#29 and #32 ), and then come back to this PR

NicolaDonelli commented 1 year ago

I had to rename the py4ai-core.typing module to py4ai-core.types module to make the TAG=$$(${PYTHON} py4ai/core/_version.py); line in the make docker_build command work (py4ai/core/_version.py contains from typing import Callable, Dict and when invoking the file directly to retrieve version number returned an error misinterpreting the typing package for the py4ai-core.typing module).

Since we are on the verge of a new major release I think this could be acceptable, what do you think @deusebio?

deusebio commented 1 year ago

Since we are on the verge of a new major release I think this could be acceptable, what do you think @deusebio?

Yes. I agree!