Nicolab / atom-local-history

Atom package for maintaining local history of files.
Other
77 stars 9 forks source link

On Windows with ByeondCompare - after succesful compare its throwing error #42

Closed Noitidart closed 8 years ago

Noitidart commented 8 years ago

I'm getting some weird behavior here.

This is my setting for diff:

"C:\Users\Mercurius\Desktop\Beyond Compare 4\BCompare.exe" "{revision-file}" "{current-file}"

When I do a diff it succesfully opens it.

But after I close the diff tool this error shows in atom:


Local history: difftool Command
Check the field value of difftool Command in your settings (local-history package).
Command error: "C:\Users\Mercurius\Desktop\Beyond Compare 4\BCompare.exe" "C:\Users\Mercurius\.atom\local-history\C\Users\Mercurius\Documents\GitHub\react-grid-layout\2016-05-21_3-19-40 PM_index.js" "C:\Users\Mercurius\Documents\GitHub\react-grid-layout\index.js"

Error details: Error: Command failed: C:\WINDOWS\system32\cmd.exe /s /c "cd C:\Users\Mercurius\Documents\GitHub\react-grid-layout && "C:\Users\Mercurius\Desktop\Beyond Compare 4\BCompare.exe" "C:\Users\Mercurius\.atom\local-history\C\Users\Mercurius\Documents\GitHub\react-grid-layout\2016-05-21_3-19-40 PM_index.js" "C:\Users\Mercurius\Documents\GitHub\react-grid-layout\index.js""
index.js26:19
CRLFUTF-8JavaScriptmaster+65, -5

Any idea why please?

Nicolab commented 8 years ago

Hello,

you can upgrade local-history with the last version (v3.3.0) published to day.

Tell me if it's ok?

Noitidart commented 8 years ago

Thank you very much for the fast reply and instant addressing of the issue! This tool is an awesome tool it would be nice if this minior issue were fixed. (also thanks for being so cool about those 3 bogus issues I made here haha)

I updated, then restarted atom but it gave me same error :(

Nicolab commented 8 years ago

I think it comes from the command. Please, try directly the command in the Windows terminal. When the command is ok in the terminal, copy the command in the local-history setting by replacing the paths with "{current-file}" and "{revision-file}".

Sorry, I do not have Windows to test.

Noitidart commented 8 years ago

It's real interesting, it's not giving me errors in the cmd.exe please see screencast - https://www.youtube.com/watch?v=ylSbTnDhUlU

I did notice something funny though. I don't know if related, but it seems to cd into a folder for no reason:

Nicolab commented 8 years ago

The cd is for working in the current directory (simpler in the case of saving new files). I watched your screencast but I do not see why the command crashes at the end, sorry :(

May be the quotes suite "cd "....""

Noitidart commented 8 years ago

Thanks @Nicolab very much for trying to help. I'll update you if I get it fixed :) The quotes didn't cause problem in the cmd.exe though, I am baffled haha but I'll keep you updated. :)

Nicolab commented 8 years ago

Ok thanks! Good luck ;)