search

Nicolab / atom-local-history

Atom package for maintaining local history of files.
Other
77 stars 9 forks source link

Object.basename is deprecated. #50

Closed ghost closed 7 years ago

ghost commented 7 years ago

Arguments to path.basename must be strings

Object.basename (C:\Users\SQ-47\AppData\Local\atom\app-1.16.0\resources\app.asar\src\electron-shims.js:31:10)
Object.getOriginBaseName (C:\Users\SQ-47\.atom\packages\local-history\lib\utils.js:29:25)
Object.getFileRevisionList (C:\Users\SQ-47\.atom\packages\local-history\lib\utils.js:51:38)
LocalHistoryView.findLocalHistory (C:\Users\SQ-47\.atom\packages\local-history\lib\local-history-view.js:137:27)
atom-workspace.<anonymous> (C:\Users\SQ-47\.atom\packages\local-history\lib\local-history.js:67:14)
CommandRegistry.handleCommandEvent (C:\Users\SQ-47\AppData\Local\atom\app-1.16.0\resources\app.asar\src\command-registry.js:259:29)
Nicolab commented 7 years ago

I could not reproduce, but I have improved the file name check. If the message persists, please give me more information (OS, context, ...).