Make highlight theme configurable

Nicolas01 / Highlightjs_Integration

A MediaWiki extension to use the client-side syntax highlighter highlight.js

GNU Affero General Public License v3.0

8 stars 3 forks source link

Make highlight theme configurable #10

Closed grusch-it closed 2 years ago

grusch-it commented 2 years ago

The default theme „vs2015“ can be overriden using the config variable

$wgHighlightJsIntegrationTheme

in LocalSettings.php

Nicolas01 commented 2 years ago

Hello @grusch-it, thanks for your participation to this project. This PR is about having a new settings parameter "HighlightJsIntegrationTheme" to allow to change the theme. But it is already possible to change the theme by changing the style file:

"styles": [
    "highlight/styles/vs2015.min.css"
],
"HighlightJsIntegrationTheme": "vs2015"

So could you explain me the benefit of this new "HighlightJsIntegrationTheme" settings parameter ?

grusch-it commented 2 years ago

You are totally right. So this pull request is more or less useless.