search

NicolasCARPi / jquery_jeditable

jQuery edit in place plugin. Extendable via plugin architecture. Plugins for plugin. Really.
https://jeditable.elabftw.net
MIT License
1.74k stars 459 forks source link

npm issue #181

Closed cfoellmann closed 6 years ago

cfoellmann commented 6 years ago

Description

when requiring the package via npm the config file is wrong.

you set "main": "jquery.jeditable.js", in https://github.com/NicolasCARPi/jquery_jeditable/blob/master/package.json#L5 That does not exist.

You need to set it to "main": "dist/jquery.jeditable.min.js", so the package can be found by npm based tools

NicolasCARPi commented 6 years ago

Hello,

Thanks for spotting and reporting the issue. I'm wondering if it should not rather be "main": "src/jquery.jeditable.js",? (non minified version)

cfoellmann commented 6 years ago

I am not an npm expert so I am not sure which one is "right". You might be right and using the non-minified version is better and can be minified by a process by the user later.

NicolasCARPi commented 6 years ago

I went with the src file ;)

cfoellmann commented 6 years ago

great. thanks for solving this so fast. 👍

NicolasCARPi commented 6 years ago

Yes, I published a new version too! (2.0.6)

cfoellmann commented 6 years ago

when is the npm reference updated? Do you know that?

NicolasCARPi commented 6 years ago

I've just pushed to npm. It is now live.

cfoellmann commented 6 years ago

thanks again. Are there no webhooks for github? for example packagist provides them for github repos

NicolasCARPi commented 6 years ago

Yes, there are webhook that could do that probably. I can also just remember to type "npm publish" after tagging a release :p