search

NicolasGoeddel / ha-sqlite2mariadb

A migration script for Homeassistant to replace SQLite with MariaDB for better performance.
GNU General Public License v3.0
1 stars 1 forks source link

Seems like it only imports the schema definitions #2

Open tbowmo opened 3 weeks ago

tbowmo commented 3 weeks ago

I'm adapting your code to do a native / haos migration, but after running the script I now end up with a database with empty tables.

Looking through the code I found this odd looking part. It seems that every db::execute just imports the schema file. Or am I missing some thing?

Also, your script ends up calling with some MYSQL_xx.. variables, even though the rest of the script uses DB_xx

NicolasGoeddel commented 3 weeks ago

Thank you for helping out with adding additional migration methods! Much appreciated. I will take a look at the odd looking part soon. At first glance it looks strange indeed. I don't know what happened there exactly.

tbowmo commented 3 weeks ago

I ran a test with my changes on a rpi with haos, and it seems to have done the right thing, as I'm now using mariadb, and have all my history from before.

Haven't done any tests with the docker compose settings, as I don't use that

NicolasGoeddel commented 3 weeks ago

That's really nice. I hope this script can be used with all kinds of installation methods in the future. Btw I started a review in #3 with a suggestions and a question.

tbowmo commented 2 days ago

Did you click "finish review"? (I can't see any comments in the pr)

NicolasGoeddel commented 2 days ago

Did you click "finish review"? (I can't see any comments in the pr)

lol. First time I am doing this on Github. That button was not that obvious like it is in Gitlab which I use mostly.

Well, sorry for the delayed review I guess. :grimacing: