NicolasGuilloux / blade-shadow-beta

Various documentation and tools for Shadow on Linux maintained by community
MIT License
119 stars 21 forks source link

Add bash script to check driver on some distros. #54

Closed aquadzn closed 4 years ago

aquadzn commented 4 years ago

done 👍

NicolasGuilloux commented 4 years ago

There is some stuff that I dislike in the script. It tries to install the driver evenif the vainfo which is very instrusive if we widespread this script for all community.

A better approach would be to test vainfo, and if it is not optimal, it checks if all the appropriate drivers are installed. If not, it asks to actually install them and recheck.

Moreover, a small warning about why we use sudo would be great aswell. Many users of the scripts we made are not good Linux users, and I guess they will start the command several times and enter their password several times aswell. Limiting that would be great :)