NicolasLM / sauna

Lightweight daemon that runs and reports health checks
https://sauna.readthedocs.io
BSD 2-Clause "Simplified" License
18 stars 10 forks source link

Fix http-json plugin by always converting expected value to string #57

Closed thbkrkr closed 7 years ago

NicolasLM commented 7 years ago

Hi Thibault,

Thank you for your contribution. It looks legit, however could you add a simple test case for this? You can add it there https://github.com/NicolasLM/sauna/blob/master/tests/test_plugins.py#L638

thbkrkr commented 7 years ago

Of course! Here is the test.

NicolasLM commented 7 years ago

Thanks, do you need a release on PyPI?

thbkrkr commented 7 years ago

It's not necessary. I run sauna in Docker by cloning a specific tag/sha1. Thanks.