search

NicolasPetton / pass

A major mode for password-store
GNU General Public License v3.0
174 stars 22 forks source link

Keybindings can shadow another mode #40

Closed doolio closed 3 years ago

doolio commented 4 years ago

Firstly, thank you for this package. Secondly, I can open this issue on your gitea instance if you prefer (and if possible). It's not clear if that's your preference from the README.

If one has set view-read-only to a non-nil value then several bindings shadow view mode bindings. This has the effect of distorting the keybinding layout in the *Password-Store* buffer as the full M-x command is visible instead. The affected bindings are as follows:

w: pass-copy r: pass-rename u: pass-copy-url n: pass-next-entry p: pass-prev-entry g: pass-update-buffer o: pass-otp-options RET: view entry (but the alternative v is displayed)

doolio commented 4 years ago

I've tried adding the following hook but to no avail.

(use-package pass
  :hook (pass-mode . (lambda ()
                       (setq-local view-read-only nil)))
  :commands pass)
cvdub commented 3 years ago

I fixed this in my pull request #46.

NicolasPetton commented 3 years ago

Fixed in PR #46.