search

NicolasPrats / DvBrowser

A browser for dataverse developers
MIT License
60 stars 8 forks source link

Dll ist blocked by the Browser when trying to rebuild #19

Open didschai opened 1 year ago

didschai commented 1 year ago

Hi, First of all - thank you so much for the Work! I tried the Browser today and it was awesome so far.

One thing I noticed was that the Plugins dll was blocked by the Browser process even though I stopped the Debugger. So I couldn't rebuild the Plugins without closing the Browser.

It would bei nice if this could be improved.

NicolasPrats commented 1 year ago

Hi, First of all - thank you so much for the Work! I tried the Browser today and it was awesome so far.

Thank you!

One thing I noticed was that the Plugins dll was blocked by the Browser process even though I stopped the Debugger. So I couldn't rebuild the Plugins without closing the Browser.

You're right. As soon as you start a session with the browser, the current implementation locks the dll. Even if you don't attach a debugger, you need to close the browser to be able to rebuild.

It would bei nice if this could be improved.

Yes, it's a good idea of improvement. I add it to my list! Thank you for the suggestion.

VanHinthem commented 11 months ago

This would be a very good addition, some kind of hot reload on plugin dll change . e

NicolasPrats commented 11 months ago

Thank you @VanHinthem for your feedback.

Certainly, I intend to:

  1. Avoid blocking the DLL (and its dependencies).
  2. Monitor the changes on dll and automatically reload the DLL and its dependency when a change occurs

I will probably not monitor changes on dependencies because it has minimum value.

I don't have any estimate date for now for the implementation of these features.

VanHinthem commented 11 months ago

@NicolasPrats thank you for the update on this. Hot reloading would be great.

Thank you for your work. This is a very good tool!