search

NicolasWebDev / reinstall-magisk-on-lineageos

Small bash script to reinstall magisk after each LineageOS update
75 stars 16 forks source link

Consider adding a check to prevent version mismatch #11

Closed galloway closed 2 years ago

galloway commented 2 years ago

Since get_url_of_latest_build() currently grabs literally the latest build, and as there has been a recent Android version update, it would be possible for a user to grab a build that would be for a different Android firmware than what is currently installed.

I don't know enough about it all to fully know what this implies, but I assume since the LineageOS team disabled automatic updates for new Android versions that it would not be fun!

adb shell getprop ro.lineage.build.version should return the current version installed.

NicolasWebDev commented 2 years ago

Hi @galloway , thanks for reporting this possible issue!

From what I found, if you download a wrong version of the build, then when rebooting, the device enters into a boot loop. In that case, reflashing with the right patched image fixes things.

But to be honest that happened to me with a wrong nightly build, but not with a wrong Android version.

Anyway, I have created PR #12 to fix that. Would you mind testing it out to see if everything is working now? I've also added some automated tests to make the script more robust.