search

NicolasWebDev / reinstall-magisk-on-lineageos

Small bash script to reinstall magisk after each LineageOS update
72 stars 15 forks source link

Avoid install Python packages with root privileges #18

Open darthr4v3m opened 1 year ago

darthr4v3m commented 1 year ago

It's a security risk to use root privileges to install Python packages from PyPI (Python Package Index). Note that anyone can upload Python packages to PyPI, including malicious ones. (for more details see https://askubuntu.com/questions/802544/is-sudo-pip-install-still-a-broken-practice/802594#802594 and https://stackoverflow.com/questions/21055859/what-are-the-risks-of-running-sudo-pip/21056000#21056000).

https://github.com/NicolasWebDev/reinstall-magisk-on-lineageos/blob/a6f91a9c06dc5ab0ee31374a1e90e86e4e14d19a/reinstall-magisk-on-lineageos#L67

darthr4v3m commented 1 year ago

(@NicolasWebDev sorry to reach out in a comment inside an issue but the link on you profile on GitHub http://kahas.net/ isn't working. May I ask if is there a way to contribute directly on your repository instead of working on a fork and propose changes from the fork? I would like to contribute proposing changes directly on the original code in a more straightforward way and avoid the extra work to maintain the fork in sync)