Open hinneLinks opened 1 year ago
On A/B phones there's already a pretty good built-in mechanism for Magisk to stay installed after an update (update without rebooting, use the Magisk Manager to patch the inactive slot, and then reboot), so this script is hopefully not something A/B phone users have to use that often anyways.
While that process sounds more convenient, it requires you to know about it before performing the LineageOS update, which is by no means a given - I didn't notice any warnings in the documentation or from within LineageOS itself about this occurring. Therefore, I still think that it would be useful if this supported A/B Boot devices.
With my Moto G7 Power, the script appeared to complete successfully without any errors, Magisk was not installed upon the phone rebooting, so clearly something failed silently.
My Phone, a Fairphone 3 uses A/B Boot (see https://source.android.com/docs/core/ota/ab#life-of-an-a-b-update). So the flash didn't work for me:
Instead i had to find the active boot slot and then use that one:
Also I wonder, if I should somehow switch the active slot to
boot_a
and flash that one, too? Or does the other one somehow magically updated after a successful boot - has anybody experience with this? Usingfastboot flash --slot=all
seems dangerous to me, if an error happens, both slots are broken.