search

Nictiz / Nictiz-R4-zib2020

NL package of FHIR R4 conformance resources for zib (Zorginformatiebouwstenen, Clinical Information Models) release 2020.
Creative Commons Zero v1.0 Universal
3 stars 3 forks source link

nl-core pkg fields missing simplifier.net #437

Closed LuukBerkel closed 6 months ago

LuukBerkel commented 6 months ago

nl-core pkg fields missing

During my research on the models for zib2020 for FHIR I came acros a problem. In het documentation is written that the zib2020 package is not suitable for implementation and the nl-core package is.

But the problem is that the nl-core package is an abstraction. Take for example the profile NameInformation. If you look at this profile on nl-core, you will be able to see that it is missing fields. But these fields are filled in on the zib2020 package. This fine over all but it raises a few questions.

Profile Name Information on nl-core package

https://simplifier.net/packages/nictiz.fhir.nl.r4.nl-core/0.10.0-beta.1/files/2195036

Profile Name Information on ZIBS package

https://simplifier.net/packages/nictiz.fhir.nl.r4.zib2020/0.10.0-beta.1/files/2194798

Does this mean we need to fill those profiles abstract profiles on our own? How can it be standard with other implementations then if you can give it your own spin? afbeelding

Sorry if this was the wrong place to ask, but i did not find a forum on this repo. Thanks in advance.

pieter-edelman-nictiz commented 6 months ago

Hi @LuukBerkel , The nl-core layer is not an abstraction of the zib layer. The zib layer is "abstract", meaning the same as in OO programming: it is a base that is not directly implementable, but meant as a base for a concrete implementation. The nl-core layer is this concrete implementation; they are derived from the zib profiles, which means that everything present in the zib profiles is also present in the nl-core profiles. So I'm wondering: what fields are you missing?

LuukBerkel commented 6 months ago

Hi @pieter-edelman-nictiz,

Thanks for your response. I seem to have made a mistake in viewing the profiles on simplifier.net. The problem was that the website simplifier,net opens the profiles standard on diff mode, and since it is based on the zib2020 package i only saw the difference and not the whole profile. That was why there were fields missing. That also why i though it was an abstraction.

afbeelding

This means that there is no issue now, and so I will close it.