search

Niek / superview

A small program that takes a 4:3 aspect ratio video file, and transforms it to a 16:9 video using the GoPro SuperView method
GNU General Public License v3.0
213 stars 21 forks source link

Output aspect ratio depends on input aspect ratio #5

Closed FieserKiller closed 4 years ago

FieserKiller commented 4 years ago

There is a bug in line 74 of the code which calculates outX wrong for input files with an aspect ratio != 4:3. I noticed because my video was 5:4 and the output file was not 16:9. Fix for converting all input files to 16:9 is quite trivial tho, simply calculate outX from input height desired ratio: outX := int(float64(specs.Streams[0].Height) (16.0 / 9.0)) / 2 * 2 // multiplier of 2

Niek commented 4 years ago

Thanks for reporting and providing the fix @FieserKiller! Fixed in https://github.com/Niek/superview/commit/2689c70c600d4ed7ce24feed868d553f2ec2c124