search

NiekertDev / Discord-MCPE

Connect your PMMP server with Discord!
Other
28 stars 17 forks source link

Fatal Error: Decleration of... #17

Closed ggomezz closed 7 years ago

ggomezz commented 7 years ago

Hello, let me make this simple. I used this .phar - https://poggit.pmmp.io/babs/66b2 I used normal plugin installation steps (Pop it in the plugins folder and do a reload) The stuff below is the console output:

Fatal error: Declaration of Niekert\DiscordMCPE\Main::onCommand(pocketmine\command\CommandSender $sender, pocketmine\command\Command $cmd, string $label, array $args) must be compatible with pocketmine\command\CommandExecutor::onCommand(pocketmine\command\CommandSender $sender, pocketmine\command\Command $command, string $label, array $args): bool in phar:// /root/plugins/Discord-MCPE.phar/src/Niekert/DiscordMCPE/Main.php on line 13 [20:52:02] [Server thread/EMERGENCY]: An unrecoverable error has occurred and the server has crashed. Creating a crash dump [20:52:02] [Server thread/EMERGENCY]: Please upload the "/root/crashdumps/Thu_Aug_3-20.52.02-UTC_2017.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.

I am running API 3.0.0-ALPHA7 on a Linux VPS Here is the crash dump: https://pastebin.com/0TrYVZeg

Thunder33345 commented 7 years ago

NOTE TO CONTRIBUTORS: this is caused by the lattest strict type API

Vaults1 commented 7 years ago

So we didn't actually support ALPHA7 properly?

Little2Epic commented 7 years ago

Can someone fix this?

NiekertDev commented 7 years ago

Sorry for late response, at holiday atm

First of all: thanks for trying my plugin!

Going to fix it for you as fast as I can

Note to devs: I thought "Poggit passed it so no problem" but not 😏

ggomezz commented 7 years ago

Alright, thank you for the continuous support through this issue!

NiekertDev commented 7 years ago

Can you try now? Build #23?

ggomezz commented 7 years ago

Alright, the startup issue has been fixed. I have not actually tried to use the plugin yet so if there appears to be some issue there then I will make sure to notify you. Thank you again!

NiekertDev commented 7 years ago

Okay.

For further issues, feel free to make an issue

Little2Epic commented 7 years ago

Can confirm it works now! Thanks so much!

DO you have any thoughts of adding a complete bridge? Any workarounds for this?

NiekertDev commented 7 years ago

I need to rewrite the plugin completely to do that. Webhooks are only one way.

NiekertDev commented 7 years ago

@Little2Epic Can you ask your question again in "Questions" issue? So people will see it

Little2Epic commented 7 years ago

Alrighty