search

NiekertDev / Discord-MCPE

Connect your PMMP server with Discord!
Other
28 stars 17 forks source link

Update for 3.0.0 API #37

Closed Aericio closed 6 years ago

Aericio commented 6 years ago

Not backwards-compatible. Tested, and everything sends.

However, if PurePerms could not be found, I just disable the plugin. Only issue is that it'll send the disable message to discord.

NiekertDev commented 6 years ago

NO WAY! The 3.0.0 is finally there! Maybe I start coding again ☺

Aericio commented 6 years ago

@NycuRO please tell me 500000 more ways to make this better plz i need help

NiekertDev commented 6 years ago

@Aericio my own code is also a mess. It needs to be rewritten almost completly :smirk:

Aericio commented 6 years ago

yeah :c

Aericio commented 6 years ago

ok i just idiot'd again

NiekertDev commented 6 years ago

It's exactly the same, only difference is that is_null is a function QUOTE

NiekertDev commented 6 years ago

As you can read, === is even faster

Aericio commented 6 years ago

@NiekertDev Yeah, that's what I read too.

Aericio commented 6 years ago

I think I'll just revert it back to !== null... what do you think?

NiekertDev commented 6 years ago

Yeah, it's alright

Aericio commented 6 years ago

I think everything is okay to push now.