Closed vaindil closed 3 years ago
Hey @NielsHeltner, hope everything is well. I'm happy to wait on this if you're just busy, but I'm also happy to take over the addon if you are no longer interested in maintaining it. Just checking, don't know if there's a different reason for the delay, and I don't want to release my own separate version without checking with you first.
Thanks for the PR and the concern. :) I'm well, just very busy with stuff that isn't WoW-related. I've added you as a collaborator on the GitHub project, so you should be able to take over maintaining it if you want to.
Glad to hear things are well, and thank you, I accepted the invite! How does Curseforge work with releases, are you able to add me there too (if you want to)? The PR was merged in but it looks like no new release was published, I don't know if it just takes some time. I'm happy to do that if you'd like, my username there is also vaindil (profile link).
I have added you on Curseforge now as well. Regarding releases, it's set up with GitHub webhooks to do automatic packaging according to https://support.curseforge.com/en/support/solutions/articles/9000197281-automatic-packaging , however it doesn't seem to have worked for this most recent release.
Thanks for that! I see that I was added to the project, but it doesn't look like I have any permissions. I tried to trigger the auto-packager manually, but I get a response saying I don't have permission to create packager requests for the project. I see you pushed another version on GitHub and it wasn't pulled in again, just trying to help figure out what's going on.
You should have permissions for that now. I also tried triggering it manually, but that doesn't seem to work either. I've created a Cuseforge ticket regarding the issue.
Thanks again! Would you mind if I uploaded a build manually? Not sure what the status of the Curseforge ticket is, and it's easy enough to do manually for now.
Finally got around to updating this for BCC. Fixes #16.
WOW_PROJECT_ID
to check game versiontbc
subdomain for BCCGetQuestFromClassicLogFocus
matching too many focuses, it should now match only the classic quest log