search

NielsHeltner / wowhead-quick-link

World of Warcraft Addon that allows you to quickly look up anything on Wowhead without having to manually search for it.
GNU General Public License v3.0
7 stars 4 forks source link

Non-latin character links #22

Open Natans8 opened 1 year ago

Natans8 commented 1 year ago

When you try to copy the link to another player's character, the Realm in the coppied link appears in that realm's original language, but in practice in the WoW website, the realm names are romanized. So the link leads me to an error page. For example,

My characters page adress is https://worldofwarcraft.com/ru-ru/character/eu/gordunni/Натаари

But when I try to copy it ingame, I get the following link: https://worldofwarcraft.com/ru-ru/character/eu/Гордунни/Натаари

Notice how the realm name here is Гордунни when in reality it should be Gordunni. I don't really know if the issue persists in other non-latin languages as well, like Chinese or Korean, but I have a reason to believe it does.

Love your addon, it's very convenient, looking forward to the next update!

vaindil commented 1 year ago

Hello again! I'm able to reproduce this behavior, but it looks like there's no API method that returns the Latin realm name necessary to properly support this. As far as I can tell, the only way to fix this would be to manually maintain a list of realms and their Latin names to do the conversion on the fly, which I'm not terribly comfortable adding to this addon.

I'll think about this in case I can come up with something better, but the solution will probably be to disable Armory links on Russian and Asian servers. I don't like that idea, but I'm not really sure what else to do.

Natans8 commented 1 year ago

Hey once again! I'm not sure how useful is this, but I managed to find This It's supposed to be an API library with the possibility of returning the english API name.