search

NielsHeltner / wowhead-quick-link

World of Warcraft Addon that allows you to quickly look up anything on Wowhead without having to manually search for it.
GNU General Public License v3.0
7 stars 4 forks source link

Keybinding category: Addons vs. AddOns #3

Closed fstenstrom closed 5 years ago

fstenstrom commented 5 years ago

Hi, just tried your addon and it's really nice! I especially like the prefix/suffix part!

There's just one thing I had a problem with: The category in the keybindings section is named "AddOn" instead of "Addon", and since my other addons such as Bagnon and MoveAnything were under the latter, I couldn't find yours at first.

I don't know what the convention is, but I just wanted to give a heads up on this.

Note: I saw that some of my addons use "Other/Others" category as well.

NielsHeltner commented 5 years ago

Thanks for the kind words, and thanks for the heads up! This is definitely a curious issue.

I chose the "AddOns" since that is how Blizzard stylizes the word, and it is actually where most of my addons are (Angry Assignments, Bagnon, SavedInstances, SilverDragon, WeakAuras). I don't have any in the "Addon" category.

I haven't been able to find anything per se in regards to a convention - the "Others" category is the default if you don't manually assign a category.

fstenstrom commented 5 years ago

Ah I see... Because it's the reverse with SilverDragon and WeakAuras for me. They just reference "ADDONS", and if I do something simple like /run print(ADDONS) with all addons disabled, this resolves to "Addons". I therefore guess that this is some global variable, and that it depends on localization (I currently use Spanish).

NielsHeltner commented 5 years ago

Aha, /run print(ADDONS) resolves to "AddOns" for me on English. Odd how the capitalization changes based on your localization. Nevertheless thank you! I would not have spotted this on my own. Fixed in 1a2a4a9 with v2.4.2.