Update puppeteer dependency to ^5.3.0 and stop using deprecated waitFor method

NielsSteensma / Dhalang

Generate PDFs and make screenshots of HTML using Puppeteer in Ruby

MIT License

40 stars 22 forks source link

Update puppeteer dependency to ^5.3.0 and stop using deprecated waitFor method #17

Closed jznadams closed 4 years ago

jznadams commented 4 years ago

With release 5.3.0 of puppeteer, the waitFor method has been deprecated and replaced with the new method waitForTimeout (which is functionally identical).

This pull request changes the minimum required version of puppeteer to be 5.3.0 and switches to the new waitForTimeout method. A side effect of using the newer version of puppeteer is that now the minimum required version of Node JS is 10.18.1.

NielsSteensma commented 4 years ago

👍 I will check the pr during the weekend.