search

NielsSteensma / Dhalang

Generate PDFs and make screenshots of HTML using Puppeteer in Ruby
MIT License
40 stars 22 forks source link

Configurable launchArgs #39

Open supairish opened 2 years ago

supairish commented 2 years ago

Hello, it doesn't appear that the puppeteer launch args are configurable.

Would you accept a PR to allow them to be?

If so, would it be ok to completely override the defaults or should it be more a provided list of additional args?

Thanks

NielsSteensma commented 2 years ago

Hi,

I guess being able to completely override the defaults would be the more flexible approach. Such a PR would be a nice addition, please feel free to open one.