NielsSteensma / Dhalang

Generate PDFs and make screenshots of HTML using Puppeteer in Ruby
MIT License
40 stars 22 forks source link

Dhalang doesn't work on Windows #55

Open NielsSteensma opened 3 months ago

NielsSteensma commented 3 months ago

When using Dhalang on Windows the following error would appear originating from the JS scripts: Unexpected token '\', "\{"webPage"... is not valid JSON

It's related to the fact that in Nodescriptinvoker.create_node_command#26 we call Shellwords.escape; this method is meant for Unix shells.

Action points: