Niemeyer-Research-Group / pyMARS

Python-based (chemical kinetic) Model Automatic Reduction Software
https://niemeyer-research-group.github.io/pyMARS/
MIT License
61 stars 46 forks source link

Refactor #53

Closed kyleniemeyer closed 5 years ago

kyleniemeyer commented 5 years ago

OK, my monster refactoring branch is, I think, ready to be merged. It does a lot:

This bypasses/closes #50 and closes #34, and

(and probably more)

codecov-io commented 5 years ago

Codecov Report

Merging #53 into master will decrease coverage by 12.63%. The diff coverage is 69.9%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #53       +/-   ##
===========================================
- Coverage   78.27%   65.64%   -12.64%     
===========================================
  Files          17       12        -5     
  Lines        1947     1170      -777     
  Branches      356      294       -62     
===========================================
- Hits         1524      768      -756     
+ Misses        371      293       -78     
- Partials       52      109       +57
Impacted Files Coverage Δ
pymars/tools.py 48.81% <ø> (ø)
pymars/__main__.py 0% <0%> (ø) :arrow_up:
pymars/pymars.py 0% <0%> (ø) :arrow_up:
pymars/reduce_model.py 100% <100%> (ø)
pymars/sampling.py 54.76% <54.76%> (ø)
pymars/soln2ck.py 62.71% <62.06%> (+59.02%) :arrow_up:
pymars/sensitivity_analysis.py 73.43% <73.01%> (-16.31%) :arrow_down:
pymars/drgep.py 76.12% <76.31%> (-11.77%) :arrow_down:
pymars/simulation.py 60% <77.55%> (-22.36%) :arrow_down:
pymars/drg.py 82.47% <81.52%> (-7.63%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c99a19...89507fd. Read the comment docs.

kyleniemeyer commented 5 years ago

IMHO the only thing I could see adding now is more testing