search

Niestrat99 / AT-Rewritten

GNU General Public License v3.0
35 stars 16 forks source link

Folia Support #104

Open AabegR opened 1 year ago

AabegR commented 1 year ago

Is your feature request related to a problem? Please describe. Advanced Teleport isn't compatible with Folia.

Describe the solution you'd like Support Folia

Describe alternatives you've considered Uhhh no one else has anything like this plugin that supports Folia

Additional context Doesn't need to be rushed but would be awesome to have it support Folia in the coming weeks! Thanks :)

Thatsmusic99 commented 1 year ago

Did want to look into Folia support and I'll be happy to cover it, that being said it'll only be for v6 of the plugin (which is, after all, targeted towards newer versions) and it may take a bit more than a few weeks with some life changes going on. :')

Thatsmusic99 commented 1 year ago

The first alpha builds for v6 with Folia support have been released on Hangar and Modrinth:

Thankfully there weren't a lot of internal changes I needed to make other than quite a bit of detangling with the RTP system.

Since Folia is in early access, these builds will remain in alpha until Folia has also left its early development cycle.

AabegR commented 1 year ago

It seems to be working quite well! Thanks a lot :)

cgw2023 commented 1 year ago

The first alpha builds for v6 with Folia support have been released on Hangar and Modrinth:

Thankfully there weren't a lot of internal changes I needed to make other than quite a bit of detangling with the RTP system.

Since Folia is in early access, these builds will remain in alpha until Folia has also left its early development cycle.

image

not sure whether it is a problem with 1.20.1 not supported i cannot run it , what should i do?

Thatsmusic99 commented 1 year ago

Hi there, due to a change in Spigot 1.20, the current builds for Folia do not work, this was hotfixed in the main AT builds (5.6.10) but it wasn't a proper fix.

I'll try and get something done today, I was hoping to get an update done on Monday but had some health concerns and issues with my PC so that was put off slightly. I'll at most try and get the v6 builds out today for both Folia and non-Folia support. It shouldn't be difficult to do.

cgw2023 commented 1 year ago

Hi there, due to a change in Spigot 1.20, the current builds for Folia do not work, this was hotfixed in the main AT builds (5.6.10) but it wasn't a proper fix.

I'll try and get something done today, I was hoping to get an update done on Monday but had some health concerns and issues with my PC so that was put off slightly. I'll at most try and get the v6 builds out today for both Folia and non-Folia support. It shouldn't be difficult to do.

Thank you so much. Take care.

Thatsmusic99 commented 1 year ago

An updated build is now available here: https://modrinth.com/plugin/advancedteleport/version/6.0.0-alpha+folia.2

AabegR commented 1 year ago

Thanks again for working on it so fast! :)

cotunjr commented 1 month ago

is there anything new? latest v6.1.1 seems like doesnt supports folia?

Thatsmusic99 commented 1 month ago

There would be a dev build available in the linked pull request, however developer builds are currently unavailable due to a problem with the CI/CD builds which also affects the main AT project.

It's not part of the mainline AT releases because there's a piece of code that relies on the internal server code, which was written due to a bug in Folia itself that has not yet received a resolution to my knowledge.