search

NiftyPET / NIPET

High-throughput PET image reconstruction with high quantitative accuracy and precision
Apache License 2.0
29 stars 7 forks source link

Bug in reconstruction pipeline #43

Closed eric2302 closed 1 year ago

eric2302 commented 2 years ago

The function mmrchain in the pipeline code pipe.py takes in a time frame, converts it into a dictionary and then tries to index it (e.g. here). This results in an error since dictionaries cannot be sliced.

Shouldn't the timing variable be t_frms = dfrms['timings'][1:]?

pjmark commented 2 years ago

dfrms['timings'] is a list, which is inside the dictionary. if you get a problem here that means there is another problem somewhere else

pjmark commented 2 years ago

have also look at here: https://niftypet.readthedocs.io/en/latest/tutorials/dynrecon/

casperdcl commented 2 years ago

Yes, this is a bug. Also multiple near-identical definitions:

https://github.com/NiftyPET/NIPET/blob/b1c3799c4a795e1db34dc36decd197ab74e95c6e/niftypet/nipet/img/auximg.py#L73

https://github.com/NiftyPET/NIPET/blob/b1c3799c4a795e1db34dc36decd197ab74e95c6e/niftypet/nipet/lm/mmrhist.py#L492