search

Nifury / ungoogled-chromium-windows

Windows packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Why "Note: Please run the PGO update script before domain substitution."? #9

Closed playgithub closed 3 years ago

playgithub commented 3 years ago

After "prune, patch, and domain substitution", I find that chrome-win64-4638-1634308623-2498f4915d99bc08c281f9554c299dbe9f88aabd.profdata in build dir doesn't change a bit.

Why should run the PGO update script before domain substitution?

Nifury commented 3 years ago

https://github.com/Nifury/ungoogled-chromium-windows/issues/4#issuecomment-950314816

You have skipped this step by downloading the new PGO profile from GitHub.

playgithub commented 3 years ago

Do you mean the PGO here (https://github.com/Nifury/ungoogled-chromium-windows/releases/download/dependency/PGO.zip) has already been cleaned?

Or after domain substitution, it'll fail to download the pgo profile?

Nifury commented 3 years ago

A new chromium version comes with a new PGO profile. The update script just pulls the PGO profile for the version. It does not modify or update the existing profiles. If the script fails for whatever reason, you can download the PGO profile from somewhere else (e.g. Release).

Yes, according to https://github.com/Nifury/ungoogled-chromium-windows/issues/4#issuecomment-950314816, the update script doesn't work after domain substitution.

playgithub commented 3 years ago

Thanks