Closed Olamyy closed 5 years ago
Failing tests. I would check this and fix them as soon as I can.
Hi @Olamyy ! Thank you very much for your PR and overall contributions!! These look like useful additions to the library! Overall, I think it might be more collaborative to discuss, design & review proposed changes before we get to the PR phase (where we're just battling Travis issues), especially to ensure that we are synchronized on goals & to get opinions like from David, Timi and others. What do you think of this approach?
Regarding the build failure, it is perhaps because you need to add an __init__.py
at the top level of the tests
directory, otherwise, without it, tests.utils
is not a package like you are using it as such. See: https://docs.pytest.org/en/latest/goodpractices.html .
Yeah. That definitely seems like a better and more organized approach to working on features. Which of github or slack do you think would be a good medium for this?
About the failing tests, I came about this same link while trying to figure out what the issue was. I just haven't looked at it in details yet. I'll get to it as soon as I can.
Thanks.
Great! Let me make a Project board and some milestones and you can add some cards, so basically github. This way the work can stay localized to the project, even if we have a higher reliance on github.
Maybe I'll take a fork of your fork and see if the __init__.py
solution will work.
The new project is here: https://github.com/Niger-Volta-LTI/iranlowo/projects
Introduces a number of changes:
Restructured the file structure by:
Converted existing tests to unittest. Major win here is that the tests are now in reusable OOP format.
Introduces some of the enhancements in #12 :