search

Niger-Volta-LTI / iranlowo

Ìrànlọ́wọ́ is a utility library for analysis & (pre)processing of Yorùbá text → https://pypi.org/project/iranlowo
MIT License
17 stars 8 forks source link

Corpus Module Cleanup #19

Open Olamyy opened 4 years ago

Olamyy commented 4 years ago

Took sometime to rework the corpus module. Major changes:

  1. Introduced a corpus and corpus path getter.
  2. A simple yaml file for keeping tracks of available datasets.
ruohoruotsi commented 4 years ago

This one is also broken, let me look at both of them and see if there isn't some meta-pattern we can adopt to facilitate a smoother PR process. I know this is painful for the Travis to be so disagreeable.

Also we might consider adopting GitHub Actions in the future, as a better CI/CD system

Olamyy commented 4 years ago

Yeah. They both break at the same point.

I added some txt and yaml files that some functions depend on. However, it doesn't seem like travis copies those when it installs the package. It's a packaging issue. I've added the paths to Manifest.in like you did for the model but that still doesn't work. I've also tried adding the paths to package_dir and data_files in setup but still, the same thing.

ruohoruotsi commented 4 years ago

no problem, working on it now ... will try some things locally, and save tests via pushes to Travis for when I'm fresher in the AM.