Rename numeric methods/types to conform with .NET conventions, #12

NightOwl888 / ICU4N

International Components for Unicode for .NET

Apache License 2.0

27 stars 7 forks source link

Rename numeric methods/types to conform with .NET conventions, #12 #76

Closed paulirwin closed 1 month ago

paulirwin commented 1 month ago

Note that I did not rename Long and Integer types in ICU4N.Support, because renaming those to Int32/Int64 would clash with the built-in .NET types. But let me know if you think those need to be renamed too.

Fixes #12

NightOwl888 commented 1 month ago

Thanks for the PR. This looks perfect.

We don't distribute the test framework, so there is no need to update those.

You didn't mark this PR with a closes #xxx or fixes #xxx. Does that mean there are/may be other names that are not in this pass?

paulirwin commented 1 month ago

Updated to add fixes line, I was unsure if you wanted to bother with Long/Integer or not. If you're good with this, this is ready to merge and close #12.