NightWhistler / PageTurner

Android e-book reader with cloud synchronization
pageturner-reader.org
GNU General Public License v3.0
466 stars 222 forks source link

epublib errors building current version #571

Closed projectgus closed 9 years ago

projectgus commented 9 years ago

Thanks for all your work on PageTurner, the updates in the past twelve months have been excellent.

I'm having a small problem. Building against the current master (d9fc355) I get the following:

/home/gus/dev/PageTurner/src/net/nightwhistler/pageturner/view/bookview/TextLoader.java:370: error: cannot find symbol
            res = new Resource( this.currentFile, res.getSize(), res.getOriginalHref() );
                                                                    ^
  symbol:   method getOriginalHref()
  location: variable res of type Resource
/home/gus/dev/PageTurner/src/net/nightwhistler/pageturner/view/bookview/EpubFontResolver.java:67: error: cannot find symbol
        Resource res = textLoader.getCurrentBook().getResources().getByFileName( resourceHRef );
                                                                 ^
  symbol:   method getByFileName(String)
  location: class Resources

I think the classes with the missing methods are nl.siegmann.epublib.domain.Resource & nl.siegmann.epublib.domain.Resources. As far as I can tell these methods don't exist in the 3.1 release or the current git master of epublib-core?

Is there an easy way around this that I'm missing? (I'm not very savvy with Java.)

Thanks!

projectgus commented 9 years ago

Never mind, figured it out. In my .m2/ directory was a cache of .jar files from the last time I built PageTurner (probably well over a year ago), and it contained an epublib-core 3.1 (the originally release). This was being pulled in instead of epublib-core 3.1 from repo.nightwhistler.org, which it turns out is actually the pageturner fork of epublib.

Removed the Maven cache and all seems to work know.

FWIW if that fork is persistent it's probably worth either bumping the version number, changing the versioning scheme, or renaming the library. :)

Cheers,

Angus