NightWhistler / PageTurner

Android e-book reader with cloud synchronization
pageturner-reader.org
GNU General Public License v3.0
466 stars 222 forks source link

Incompatibility with Google's AppCompat library #580

Open vinaywadhwa opened 9 years ago

vinaywadhwa commented 9 years ago

Hi,

This is the kind of conflict errors i get when i build my project which refers(depends upon) to AppCompatV7 and PageTurner>(or any other library project which has ActionBarSherlock as a dependency)

Error:Attribute "titleTextStyle" has already been defined Error:Attribute "subtitleTextStyle" has already been defined Error:Attribute "divider" has already been defined Error:Attribute "background" has already been defined Error:Attribute "backgroundSplit" has already been defined Error:Attribute "navigationMode" has already been defined Error:Attribute "displayOptions" has already been defined Error:Attribute "title" has already been defined Error:Attribute "subtitle" has already been defined Error:Attribute "icon" has already been defined Error:Attribute "logo" has already been defined Error:Attribute "backgroundStacked" has already been defined Error:Attribute "customNavigationLayout" has already been defined Error:Attribute "homeLayout" has already been defined Error:Attribute "progressBarStyle" has already been defined Error:Attribute "indeterminateProgressStyle" has already been defined Error:Attribute "progressBarPadding" has already been defined Error:Attribute "itemPadding" has already been defined Error:Attribute "initialActivityCount" has already been defined Error:Attribute "expandActivityOverflowButtonDrawable" has already been defined Error:Attribute "preserveIconSpacing" has already been defined Error:Attribute "iconifiedByDefault" has already been defined Error:Attribute "queryHint" has already been defined Error:Attribute "windowActionBar" has already been defined Error:Attribute "windowActionBarOverlay" has already been defined Error:Attribute "windowActionModeOverlay" has already been defined Error:Attribute "actionBarTabStyle" has already been defined Error:Attribute "actionBarTabBarStyle" has already been defined Error:Attribute "actionBarTabTextStyle" has already been defined Error:Attribute "actionOverflowButtonStyle" has already been defined Error:Attribute "actionBarStyle" has already been defined Error:Attribute "actionBarSplitStyle" has already been defined Error:Attribute "actionBarWidgetTheme" has already been defined Error:Attribute "actionBarSize" has already been defined Error:Attribute "actionBarDivider" has already been defined Error:Attribute "actionBarItemBackground" has already been defined Error:Attribute "actionMenuTextAppearance" has already been defined Error:Attribute "actionMenuTextColor" has already been defined Error:Attribute "actionModeStyle" has already been defined Error:Attribute "actionModeCloseButtonStyle" has already been defined Error:Attribute "actionModeBackground" has already been defined Error:Attribute "actionModeSplitBackground" has already been defined Error:Attribute "actionModeCloseDrawable" has already been defined Error:Attribute "actionModeShareDrawable" has already been defined Error:Attribute "actionModePopupWindowStyle" has already been defined Error:Attribute "textAppearanceLargePopupMenu" has already been defined Error:Attribute "textAppearanceSmallPopupMenu" has already been defined Error:Attribute "actionDropDownStyle" has already been defined Error:Attribute "dropdownListPreferredItemHeight" has already been defined Error:Attribute "spinnerDropDownItemStyle" has already been defined Error:Attribute "homeAsUpIndicator" has already been defined Error:Attribute "actionButtonStyle" has already been defined Error:Attribute "selectableItemBackground" has already been defined Error:Attribute "dividerVertical" has already been defined Error:Attribute "activityChooserViewStyle" has already been defined Error:Attribute "popupMenuStyle" has already been defined Error:Attribute "textAppearanceSearchResultTitle" has already been defined Error:Attribute "textAppearanceSearchResultSubtitle" has already been defined Error:Attribute "textColorSearchUrl" has already been defined Error:Attribute "listPreferredItemHeightSmall" has already been defined Error:Attribute "listPreferredItemPaddingLeft" has already been defined Error:Attribute "listPreferredItemPaddingRight" has already been defined Error:Attribute "dropDownListViewStyle" has already been defined Error:Attribute "listPopupWindowStyle" has already been defined Error:Attribute "textAppearanceListItemSmall" has already been defined

NightWhistler commented 9 years ago

Hi Vinay,

I've started following the instructions here https://www.grokkingandroid.com/migrating-actionbarsherlock-actionbarcompat/

to remove ActionBarSherlock from the codebase.

I'll push the work to a separate branch.

mmrasheed commented 8 years ago

Hi Alex, Is there any progress in migrating from actionbarsherlock to appcompat?

I have been trying the migration myself for last few days, but couldn't overcome few errors. I followed the guideline you mentioned above strictly. I also followed quick instructions from http://stackoverflow.com/questions/20933944/what-are-the-common-issues-when-migrating-from-actionbarsherlock-to-actionbarcom , but without luck.

Moreover, the latest android SDK, 23.x, has removed apache http permanently, rendering Pageturner incompatible with Android 6.0.

Any chance we get this project migrated to appcompat anytime soon?

vinaywadhwa commented 8 years ago

Alex did another branch for ActionBarSherlock TO AppCompat migration- https://github.com/NightWhistler/PageTurner/tree/appcompatv7

Also, you can still use Apache's HTTP in 6.0

mmrasheed commented 8 years ago

Thanks vinaywadhwa, I found that out soon after replying here. That appcompat version compiles fine using terminal command, but showing error in Android Studio. Deatils about this issue at https://github.com/NightWhistler/PageTurner/issues/589

NightWhistler commented 8 years ago

The AppCompat branch works and compiles OK, but if I remember correctly it causes some Exceptions when run on older Android versions (Android 2.2 I think).

That's the reason the changes have not been merged to master yet.