search

Nightfirecat / RealmEye-API

An easy way to access your character data via RealmEye.
MIT License
13 stars 7 forks source link

Add notice regarding deploy.php's use of `shell_exec` #30

Closed Nightfirecat closed 7 years ago

Nightfirecat commented 8 years ago

Not all systems will have this enabled, and it is a risky feature for shared environments to use. The readme should reflect this.

Nightfirecat commented 8 years ago

The script should also probably make a check for this. If a system has shell_exec() disabled, we shouldn't be trying to run it.

Nightfirecat commented 7 years ago

I'm highly considering scrapping this, and just rewriting the shell portion as an actual shell script, and using proc_open() to bypass this glaring security vulnerability.