search

Nighthawk3D / klipper_lcd_menu

A custom menu system for LCD displays on klipper based printers.
9 stars 2 forks source link

Only first two lines of the display are used #2

Open MarSoft opened 3 months ago

MarSoft commented 3 months ago

Looks like the __voron_display display_data group only uses the first two rows of the 4-row display. Strange; it declares 4 rows, but only first 2 are displayed in fact. Maybe a problem with my configuration? But all 4 rows are shown by default (display is mini12864).

Nighthawk3D commented 3 months ago

Do you have an enclosure temperature sensor? It needs to be named "chamber"

[temperature_sensor chamber]
sensor_type: Generic 3950
sensor_pin: PA1
min_temp: 0
max_temp: 100
gcode_id: C

It should look like this: IMG_5279

MarSoft commented 3 months ago

No, I don't have an enclosure sensor (or enclosure itself). Could it be the reason why all the remaining fields in the lower 2 lines are hidden?

MarSoft commented 3 months ago

Confirmed. The bug disappeared after adding this line to my config file:

[display_data __voron_display chamber]
text: ~chamber~ 0~degrees~

Looks like any exception raised when rendering display text will stop rendering the remaining display sections.

Nighthawk3D commented 3 months ago

I have a fix for it that I will push to the repo soon. Not sure that setting it to 0 is the best option here or leaving that entire display section blank.

The fix will be an additional variable in the lcd_menu_settings.cfg file to control the chamber display section.

Nighthawk3D commented 3 months ago

Optionally you could also just comment out this line in lcd_menu_settings.cfg and revert to the stock display layout where the chamber sensor isn't part of the layout.

[include ./lcd_menu/lcd_tweaks.cfg]