search

Nightinggale / ONI-mods

GNU General Public License v3.0
23 stars 24 forks source link

Max Gas Pressure #6

Open 89gsc opened 5 years ago

89gsc commented 5 years ago

I assume this is an issue for other items as well but I noticed this with the electrolyser.

If the electrolyser has both outputs pipped and the atmosphere around it is at max gas pressure it will stop outputting.

I have confirmed there was no issue in either output being able to take more gas.

Truinto commented 5 years ago

That's just a property of that building. It will check the gas pressure it's in an turn off when it's over 1800g. I am planning to make that configurable in my mod, if that helps. Probably updating some time today.

Nightinggale commented 5 years ago

It's intended behavior... sort of. The problem is that the electrolyzer component will stop working if the room pressure is higher than a certain threshold. This component has no knowledge of any mods.

The problem is that fixing this requires modding something, which isn't easy to mod and depending on implementation both performance and mod compatibility could suffer.

I am planning to make that configurable in my mod, if that helps.

It's easy to mod the threshold or make the threshold go away entirely. The problem is if the threshold should go away if both pipes are connected, but be applied if one or both output pipes are missing. Any non-complex solution would require both cases to use the same threshold.

However ideas are welcome.

corrado33 commented 5 years ago

While this issue is technically true (and the same thing with the oxygen diffuser), it's not entirely hard to fix (in game.) A simple small pump with an atmo sensor works fine. I just think of it as "leakage." That's fixed the issue for my electrolyzer room (4 electrolyzers) for hundreds of cycles now. The interesting thing to me is that the the hydrogen doesn't seem to leak, just the oxygen. Even though I have both piped.