NightlyRevenger / TataruHelper

Tataru Helper - application for translation of in-game texts in Japan MMORPG - Final Fantasy XIV. The texts are understood as MSQ, cutscenes, quests, NPC replicas, etc.
https://github.com/NightlyRevenger/TataruHelper/releases/latest
MIT License
310 stars 45 forks source link

DeepL not translating words followed by "—" #31

Closed fealaure closed 2 years ago

fealaure commented 3 years ago

Since DeepL recently became my prefered tool for translation I wish to use it in Tataru helper for Brazilian Portuguese but everytime a word comes followed by a dash character (—) the text is not translated. I tried to do the fix myself since I'm a developer too, but I'm not very used to .NET I also want to ask if possible to add the steps to build the project in Visual Studio in the README file I tried to run here but I got errors in every engine except for Baidu.

I also want to mention that the Portuguese configured for translation on DeepL is not Brazilian Portuguese, it would be great if there was the possibility of including both portuguese from portugal (PT-PT) and portuguese from Brazil (PT-BR). I saw that there is a JSON file that configure the languages settings for the engines, I guess it is quite simple to add this.

xDarkOne commented 3 years ago

We will fix it

xDarkOne commented 2 years ago

Fixed